Skip to content

Commit 518a94c

Browse files
committed
[DES-195] apply ruff format to drifted files
Four files drifted from `ruff format` between recent merges and were failing `uv run ruff format --check packages/` on CI: - chat-adapter-shared: card_utils.py + test_card_utils.py - chat-adapter-state-memory: __init__.py + test_memory_state_adapter.py Purely formatting; no semantic changes.
1 parent 6f2c705 commit 518a94c

4 files changed

Lines changed: 46 additions & 68 deletions

File tree

packages/chat-adapter-shared/src/chat_adapter_shared/card_utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ def _child_to_fallback_text(
138138
return "\n".join(
139139
t
140140
for t in (
141-
_child_to_fallback_text(c, convert_text)
142-
for c in _get(child, "children", []) or []
141+
_child_to_fallback_text(c, convert_text) for c in _get(child, "children", []) or []
143142
)
144143
if t
145144
)

packages/chat-adapter-shared/tests/test_card_utils.py

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,7 @@ def test_uses_double_asterisks_for_markdown_bold_format(self) -> None:
181181

182182
def test_uses_double_line_breaks_when_specified(self) -> None:
183183
card = Card(title="Title", subtitle="Subtitle")
184-
assert (
185-
card_to_fallback_text(card, {"line_break": "\n\n"})
186-
== "*Title*\n\nSubtitle"
187-
)
184+
assert card_to_fallback_text(card, {"line_break": "\n\n"}) == "*Title*\n\nSubtitle"
188185

189186
def test_formats_text_children(self) -> None:
190187
card = Card(title="Card", children=[CardText("Some content")])
@@ -193,10 +190,12 @@ def test_formats_text_children(self) -> None:
193190
def test_formats_fields(self) -> None:
194191
card = Card(
195192
children=[
196-
Fields([
197-
Field(label="Name", value="John"),
198-
Field(label="Age", value="30"),
199-
]),
193+
Fields(
194+
[
195+
Field(label="Name", value="John"),
196+
Field(label="Age", value="30"),
197+
]
198+
),
200199
],
201200
)
202201
assert card_to_fallback_text(card) == "Name: John\nAge: 30"
@@ -208,10 +207,12 @@ def test_formats_fields_as_label_value_pairs(self) -> None:
208207
def test_excludes_actions_from_fallback_text(self) -> None:
209208
card = Card(
210209
children=[
211-
Actions([
212-
Button(id="ok", label="OK"),
213-
Button(id="cancel", label="Cancel"),
214-
]),
210+
Actions(
211+
[
212+
Button(id="ok", label="OK"),
213+
Button(id="cancel", label="Cancel"),
214+
]
215+
),
215216
],
216217
)
217218
assert card_to_fallback_text(card) == ""
@@ -243,14 +244,18 @@ def test_handles_complex_card_with_all_elements(self) -> None:
243244
children=[
244245
CardText("Thank you for your purchase!"),
245246
Divider(),
246-
Fields([
247-
Field(label="Status", value="Processing"),
248-
Field(label="Total", value="$99.99"),
249-
]),
250-
Actions([
251-
Button(id="view", label="View Order", style="primary"),
252-
Button(id="cancel", label="Cancel", style="danger"),
253-
]),
247+
Fields(
248+
[
249+
Field(label="Status", value="Processing"),
250+
Field(label="Total", value="$99.99"),
251+
]
252+
),
253+
Actions(
254+
[
255+
Button(id="view", label="View Order", style="primary"),
256+
Button(id="cancel", label="Cancel", style="danger"),
257+
]
258+
),
254259
],
255260
)
256261

packages/chat-adapter-state-memory/src/chat_adapter_state_memory/__init__.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,7 @@ async def append_to_list(
281281
cached = self._cache.get(key)
282282
list_value: list[Any]
283283

284-
if (
285-
cached is not None
286-
and cached.expires_at is not None
287-
and cached.expires_at <= _now_ms()
288-
):
284+
if cached is not None and cached.expires_at is not None and cached.expires_at <= _now_ms():
289285
list_value = []
290286
elif cached is not None and isinstance(cached.value, list):
291287
list_value = cached.value
@@ -363,9 +359,7 @@ async def queue_depth(self, thread_id: str) -> int:
363359

364360
def _ensure_connected(self) -> None:
365361
if not self._connected:
366-
raise RuntimeError(
367-
"MemoryStateAdapter is not connected. Call connect() first."
368-
)
362+
raise RuntimeError("MemoryStateAdapter is not connected. Call connect() first.")
369363

370364
def _clean_expired_locks(self) -> None:
371365
now = _now_ms()

packages/chat-adapter-state-memory/tests/test_memory_state_adapter.py

Lines changed: 18 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,13 @@ async def test_should_not_release_a_lock_with_wrong_token(
7373
lock = await adapter.acquire_lock("thread1", 5000)
7474
assert lock is not None
7575

76-
await adapter.release_lock({
77-
"thread_id": "thread1",
78-
"token": "fake-token",
79-
"expires_at": 0,
80-
})
76+
await adapter.release_lock(
77+
{
78+
"thread_id": "thread1",
79+
"token": "fake-token",
80+
"expires_at": 0,
81+
}
82+
)
8183

8284
# Original lock should still be held
8385
lock2 = await adapter.acquire_lock("thread1", 5000)
@@ -86,9 +88,7 @@ async def test_should_not_release_a_lock_with_wrong_token(
8688
# Clean up
8789
await adapter.release_lock(lock)
8890

89-
async def test_should_allow_re_locking_after_expiry(
90-
self, adapter: MemoryStateAdapter
91-
) -> None:
91+
async def test_should_allow_re_locking_after_expiry(self, adapter: MemoryStateAdapter) -> None:
9292
lock1 = await adapter.acquire_lock("thread1", 10) # 10ms TTL
9393

9494
await asyncio.sleep(0.020) # 20ms
@@ -127,9 +127,7 @@ async def test_should_no_op_when_force_releasing_a_non_existent_lock(
127127
result = await adapter.force_release_lock("nonexistent")
128128
assert result is None
129129

130-
async def test_should_not_extend_an_expired_lock(
131-
self, adapter: MemoryStateAdapter
132-
) -> None:
130+
async def test_should_not_extend_an_expired_lock(self, adapter: MemoryStateAdapter) -> None:
133131
lock = await adapter.acquire_lock("thread1", 10)
134132
assert lock is not None
135133

@@ -152,26 +150,20 @@ async def test_should_set_a_value_when_key_does_not_exist(
152150
assert result is True
153151
assert await adapter.get("key1") == "value1"
154152

155-
async def test_should_not_overwrite_an_existing_key(
156-
self, adapter: MemoryStateAdapter
157-
) -> None:
153+
async def test_should_not_overwrite_an_existing_key(self, adapter: MemoryStateAdapter) -> None:
158154
await adapter.set_if_not_exists("key1", "first")
159155
result = await adapter.set_if_not_exists("key1", "second")
160156
assert result is False
161157
assert await adapter.get("key1") == "first"
162158

163-
async def test_should_allow_setting_after_ttl_expiry(
164-
self, adapter: MemoryStateAdapter
165-
) -> None:
159+
async def test_should_allow_setting_after_ttl_expiry(self, adapter: MemoryStateAdapter) -> None:
166160
await adapter.set_if_not_exists("key1", "first", 10)
167161
await asyncio.sleep(0.020)
168162
result = await adapter.set_if_not_exists("key1", "second")
169163
assert result is True
170164
assert await adapter.get("key1") == "second"
171165

172-
async def test_should_respect_ttl_on_the_new_value(
173-
self, adapter: MemoryStateAdapter
174-
) -> None:
166+
async def test_should_respect_ttl_on_the_new_value(self, adapter: MemoryStateAdapter) -> None:
175167
await adapter.set_if_not_exists("key1", "value", 10)
176168
await asyncio.sleep(0.020)
177169
assert await adapter.get("key1") is None
@@ -183,9 +175,7 @@ async def test_should_respect_ttl_on_the_new_value(
183175

184176

185177
class TestAppendToListGetList:
186-
async def test_should_append_and_retrieve_list_items(
187-
self, adapter: MemoryStateAdapter
188-
) -> None:
178+
async def test_should_append_and_retrieve_list_items(self, adapter: MemoryStateAdapter) -> None:
189179
await adapter.append_to_list("list1", {"id": 1})
190180
await adapter.append_to_list("list1", {"id": 2})
191181

@@ -228,18 +218,14 @@ async def test_should_refresh_ttl_on_subsequent_appends(
228218
result = await adapter.get_list("list1")
229219
assert result == [{"id": 1}, {"id": 2}]
230220

231-
async def test_should_keep_lists_isolated_by_key(
232-
self, adapter: MemoryStateAdapter
233-
) -> None:
221+
async def test_should_keep_lists_isolated_by_key(self, adapter: MemoryStateAdapter) -> None:
234222
await adapter.append_to_list("list-a", "a")
235223
await adapter.append_to_list("list-b", "b")
236224

237225
assert await adapter.get_list("list-a") == ["a"]
238226
assert await adapter.get_list("list-b") == ["b"]
239227

240-
async def test_should_start_fresh_after_expired_list(
241-
self, adapter: MemoryStateAdapter
242-
) -> None:
228+
async def test_should_start_fresh_after_expired_list(self, adapter: MemoryStateAdapter) -> None:
243229
await adapter.append_to_list("list1", {"id": 1}, {"ttl_ms": 10})
244230
await asyncio.sleep(0.020)
245231

@@ -353,9 +339,7 @@ async def test_should_handle_max_size_of_one_debounce_behavior(
353339
result = await adapter.dequeue("thread1")
354340
assert result["message"] == {"id": "m3"}
355341

356-
async def test_should_keep_queues_isolated_by_thread(
357-
self, adapter: MemoryStateAdapter
358-
) -> None:
342+
async def test_should_keep_queues_isolated_by_thread(self, adapter: MemoryStateAdapter) -> None:
359343
await adapter.enqueue(
360344
"thread-a",
361345
{"message": {"id": "a1"}, "enqueued_at": 1000, "expires_at": 90000},
@@ -376,9 +360,7 @@ async def test_should_keep_queues_isolated_by_thread(
376360
rb = await adapter.dequeue("thread-b")
377361
assert rb["message"] == {"id": "b1"}
378362

379-
async def test_should_clear_queues_on_disconnect(
380-
self, adapter: MemoryStateAdapter
381-
) -> None:
363+
async def test_should_clear_queues_on_disconnect(self, adapter: MemoryStateAdapter) -> None:
382364
await adapter.enqueue(
383365
"thread1",
384366
{"message": {"id": "m1"}, "enqueued_at": 1000, "expires_at": 90000},
@@ -403,9 +385,7 @@ async def test_should_throw_when_not_connected(self) -> None:
403385
with pytest.raises(RuntimeError, match="not connected"):
404386
await new_adapter.subscribe("test")
405387

406-
async def test_should_clear_state_on_disconnect(
407-
self, adapter: MemoryStateAdapter
408-
) -> None:
388+
async def test_should_clear_state_on_disconnect(self, adapter: MemoryStateAdapter) -> None:
409389
await adapter.subscribe("thread1")
410390
await adapter.acquire_lock("thread1", 5000)
411391

0 commit comments

Comments
 (0)