Skip to content

Commit 884a2c0

Browse files
fix(ci): build every package before the coverage job (#1005)
The coverage job built only abi-registry, so any test importing across workspace packages died on "Failed to resolve entry for package @orbital-stellar/pulse-core" - packages resolve each other through main (./dist/index.js), which does not exist until build runs. Co-authored-by: Salmatcre8 <118213044+Salmatcre8@users.noreply.github.com>
1 parent f7d733f commit 884a2c0

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,12 @@ jobs:
279279
node-version: 20
280280
cache: pnpm
281281
- run: pnpm install --frozen-lockfile
282-
- name: Build abi-registry
283-
run: pnpm tsc -p packages/abi-registry/tsconfig.json
282+
# Every package must be built, not just abi-registry: workspace packages
283+
# resolve each other through their published `main` (./dist/index.js), so
284+
# a cross-package import in a test file - e.g. anchor-sdk's sep10 suite
285+
# importing WebAuth from pulse-core - fails to resolve without a dist.
286+
- name: Build packages
287+
run: pnpm build
284288
- name: Run coverage (thresholds enforced)
285289
run: pnpm -r --if-present test:coverage
286290
- name: Upload coverage reports

0 commit comments

Comments
 (0)