Skip to content

Commit f484356

Browse files
committed
fix: add skipStatusFilter prop to data tables to fix bug comes from my earlier commit
1 parent 1b1f5d2 commit f484356

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

frontend-nextjs/src/app/[lang]/dashboard/organisation/[orgId]/campaigns/[campaignId]/applications/data-table-all.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export function ApplicationSummaryDataTableAll<TData, TValue>({
3939
setColumnFilters={setColumnFilters}
4040
columnFilters={columnFilters}
4141
label="To Review"
42+
skipStatusFilter
4243
color="bg-gray-200"
4344
orgId={orgId}
4445
campaignId={campaignId}
@@ -47,6 +48,7 @@ export function ApplicationSummaryDataTableAll<TData, TValue>({
4748

4849
<ApplicationSummaryDataTable
4950
label="Review"
51+
skipStatusFilter
5052
color="bg-gray-200"
5153
dict={dict}
5254
renderSubComponent={renderSubComponent}

frontend-nextjs/src/app/[lang]/dashboard/organisation/[orgId]/campaigns/[campaignId]/applications/data-table.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ interface DataTableProps<TData, TValue> {
4242
color: string;
4343
label: string;
4444
sendEmails?: boolean;
45+
skipStatusFilter?: boolean;
4546
}
4647

4748
function toApplicant(
@@ -74,6 +75,7 @@ export function ApplicationSummaryDataTable<
7475
color,
7576
label,
7677
sendEmails,
78+
skipStatusFilter,
7779
}: DataTableProps<TData, TValue>) {
7880
const router = useRouter();
7981
const colorMap: Record<string, string> = {
@@ -82,8 +84,9 @@ export function ApplicationSummaryDataTable<
8284
};
8385

8486
const filteredMembers = useMemo(() => {
87+
if (skipStatusFilter) return data;
8588
return data.filter((m) => m.private_status === label);
86-
}, [data, label]);
89+
}, [data, label, skipStatusFilter]);
8790

8891
const table = useReactTable<TData>({
8992
data: filteredMembers,

0 commit comments

Comments
 (0)