Skip to content

Commit cc1cdd4

Browse files
marc0oloclaude
andcommitted
fix: pin Motoko recipe to immutable commit SHA
Both Motoko examples now point to the specific commit of the fix branch rather than the branch name, which is mutable. Swap to a stable @dfinity/motoko release tag once dfinity/icp-cli-recipes#26 ships. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 9b30706 commit cc1cdd4

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

AGENTS.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,9 +352,15 @@ All devcontainer configs and CI workflows currently reference `ghcr.io/marc0olo/
352352
Also note: `icp-dev-env-all` is a new combined Motoko+Rust image (for the root devcontainer) that does not yet exist in the dfinity org.
353353

354354
### Motoko recipe version
355-
`motoko/who_am_i/icp.yaml` pins a raw GitHub URL to pick up `[moc] args` support before it ships in a stable release. Once https://github.com/dfinity/icp-cli-recipes/pull/26 merges and a new `@dfinity/motoko` version is released, update:
356-
- `motoko/who_am_i/icp.yaml`
357-
- `motoko/hello_world/icp.yaml`
355+
Both `motoko/who_am_i/icp.yaml` and `motoko/hello_world/icp.yaml` pin a specific commit SHA of the Motoko recipe to pick up `[moc] args` support from `mops.toml` before it ships in a stable release:
356+
357+
```yaml
358+
type: https://raw.githubusercontent.com/dfinity/icp-cli-recipes/bc9581d9258d2d7feb15ab4ae8d04baf923b985f/recipes/motoko/recipe.hbs
359+
```
360+
361+
Tracked in: https://github.com/dfinity/icp-cli-recipes/pull/26
362+
363+
Once that PR merges and a new `@dfinity/motoko` version is released, replace the raw URL in both files with the versioned tag (e.g. `@dfinity/motoko@vX.Y.Z`).
358364

359365
---
360366

motoko/hello_world/icp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
canisters:
22
- name: backend
33
recipe:
4-
type: "@dfinity/motoko@v4.1.0"
4+
type: https://raw.githubusercontent.com/dfinity/icp-cli-recipes/bc9581d9258d2d7feb15ab4ae8d04baf923b985f/recipes/motoko/recipe.hbs
55
configuration:
66
main: backend/app.mo
77
candid: backend/backend.did

motoko/who_am_i/icp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ networks:
66
canisters:
77
- name: backend
88
recipe:
9-
type: https://raw.githubusercontent.com/dfinity/icp-cli-recipes/refs/heads/fix/motoko-mops-moc-args/recipes/motoko/recipe.hbs
9+
type: https://raw.githubusercontent.com/dfinity/icp-cli-recipes/bc9581d9258d2d7feb15ab4ae8d04baf923b985f/recipes/motoko/recipe.hbs
1010
configuration:
1111
main: src/backend/main.mo
1212
candid: src/backend/backend.did

0 commit comments

Comments
 (0)