refactor: simplify explanation for exposed ports for httpGet in probes#312
Open
BoboTheBarbar wants to merge 4 commits into
Open
refactor: simplify explanation for exposed ports for httpGet in probes#312BoboTheBarbar wants to merge 4 commits into
BoboTheBarbar wants to merge 4 commits into
Conversation
I think there is no reason to illustrate an exposed containerport 80, since it would obfuscate that there is no reason for this port to be exposed.
Owner
|
sorry, what's wrong with exposing the default nginx port? |
andrzejsydor
approved these changes
Apr 4, 2023
Author
There is nothing wrong with exposing it. But the task requires to run a readyness probe and verify the port 80 is in use. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I think there is no reason to illustrate an exposed containerport 80, since it would obfuscate that there is no reason for this port to be exposed.