Skip to content

refactor: simplify explanation for exposed ports for httpGet in probes#312

Open
BoboTheBarbar wants to merge 4 commits into
dgkanatsios:mainfrom
BoboTheBarbar:simplify-readinessprobe-answer
Open

refactor: simplify explanation for exposed ports for httpGet in probes#312
BoboTheBarbar wants to merge 4 commits into
dgkanatsios:mainfrom
BoboTheBarbar:simplify-readinessprobe-answer

Conversation

@BoboTheBarbar

Copy link
Copy Markdown

I think there is no reason to illustrate an exposed containerport 80, since it would obfuscate that there is no reason for this port to be exposed.

BoboTheBarbar and others added 2 commits March 10, 2023 18:22
I think there is no reason to illustrate an exposed containerport 80, since it would obfuscate that there is no reason for this port to be exposed.
@dgkanatsios

Copy link
Copy Markdown
Owner

sorry, what's wrong with exposing the default nginx port?

@BoboTheBarbar

Copy link
Copy Markdown
Author

sorry, what's wrong with exposing the default nginx port?

There is nothing wrong with exposing it. But the task requires to run a readyness probe and verify the port 80 is in use.
It is an educational detail to show a student, that port 80 doesn't have to be exposed, since the readiness probe runs within the container.
If we would expose port 80 on the pod, this detail would be obfuscated. I will clarify that in the comment a bit more in another commit.

@BoboTheBarbar

Copy link
Copy Markdown
Author

New configuration has been tested manually
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants