Skip to content

Commit 8ae19bc

Browse files
Dhawal Rankaclaude
authored andcommitted
security.yml: allow the cargo-geiger matrix-voice step to fail without blocking (repo owner decision)
Confirmed upstream tool bug, not a code defect: cargo-geiger 0.13.0 (latest release; 0.12.0 reproduces identically) bundles cargo 0.86.0 as a library, whose internal clean/download-batching panics on this project's matrix-voice dependency graph with "assertion failed: self.pending_ids.insert(id)" in cargo::core::package::Downloads::start. Reproduced locally, independent of CI, on both available cargo-geiger releases. No newer release exists. cargo check/build/test for matrix-voice all pass clean. Matches the existing continue-on-error precedent already on the cargo audit step in this same job. Every other step in dependency-and-secret-audit (secret scanning, SBOM, license/source policy, other feature scans) still blocks normally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent e736355 commit 8ae19bc

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

.github/workflows/security.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,20 @@ jobs:
9696
run: cargo deny --locked check licenses sources
9797
- name: Record Matrix voice unsafe-code inventory
9898
working-directory: mesh/src-tauri
99+
# cargo-geiger 0.13.0 (the latest release; 0.12.0 reproduces identically)
100+
# bundles cargo 0.86.0 as a library, whose internal clean/download-batching
101+
# panics on this project's matrix-voice dependency graph:
102+
# "assertion failed: self.pending_ids.insert(id)" in
103+
# cargo::core::package::Downloads::start, called from cargo_geiger's own
104+
# pre-scan cargo_clean::clean step. Confirmed independent of this repo's
105+
# code: cargo check/build/test for matrix-voice all pass clean, and the
106+
# crash reproduces locally with no CI-specific factors involved. No newer
107+
# cargo-geiger exists to fix it. continue-on-error so this known upstream
108+
# tool bug doesn't block merges; every other step in this job (secret
109+
# scanning, SBOM, license/source policy, other feature scans) still
110+
# blocks normally. Matches the existing continue-on-error precedent on
111+
# the cargo audit step above.
112+
continue-on-error: true
99113
run: >-
100114
cargo geiger
101115
--no-default-features

0 commit comments

Comments
 (0)