Do not log Not Found errors

Author: noteflakes

TODO.md

@@ -1,8 +1,5 @@
 ## Immediate
 
-- [ ] On internal error in module, default response should be to display page
-  showing error, with auto refresh on file change
-- [ ] Do not log error backtrace for 404 errors (or other )
 - [ ] Collection - treat directories and files as collections of data.
 
   Kind of similar to the routing tree, but instead of routes it just takes a

lib/syntropy/app.rb

@@ -76,7 +76,7 @@ def call(req)
         method: req.method,
         path: req.path,
         error: e
-      )
+      ) if Error.log_error?(e)
       error_handler = get_error_handler(route)
       error_handler.(req, e)
     end

lib/syntropy/errors.rb

@@ -8,7 +8,7 @@ class Error < StandardError
     Status = Qeweney::Status
 
     # By default, the HTTP status for errors is 500 Internal Server Error
-    DEFAULT_STATUS = Qeweney::Status::INTERNAL_SERVER_ERROR
+    DEFAULT_STATUS = Status::INTERNAL_SERVER_ERROR
 
     # Returns the HTTP status for the given exception
     #
@@ -18,6 +18,10 @@ def self.http_status(err)
       err.respond_to?(:http_status) ? err.http_status : DEFAULT_STATUS
     end
 
+    def self.log_error?(err)
+      http_status(err) != Status::NOT_FOUND
+    end
+
     # Creates an error with status 404 Not Found
     #
     # @return [Syntropy::Error]
@@ -49,14 +53,14 @@ def initialize(msg = 'Internal server error', http_status = DEFAULT_STATUS)
     #
     # @return [Integer, String] HTTP status
     def http_status
-      @http_status || Qeweney::Status::INTERNAL_SERVER_ERROR
+      @http_status || Status::INTERNAL_SERVER_ERROR
     end
   end
 
   # ValidationError is raised when a validation has failed.
   class ValidationError < Error
     def initialize(msg)
-      super(msg, Qeweney::Status::BAD_REQUEST)
+      super(msg, Status::BAD_REQUEST)
     end
   end
 end