Skip to content

Commit 7ea4e1a

Browse files
committed
Comment out profiling code
1 parent f67ed61 commit 7ea4e1a

1 file changed

Lines changed: 29 additions & 30 deletions

File tree

ext/um/um.c

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ inline struct io_uring_sqe *um_get_sqe(struct um *machine, struct um_op *op) {
6262
machine->metrics.ops_unsubmitted, machine->metrics.ops_pending, machine->metrics.total_ops
6363
);
6464

65-
struct io_uring_sqe *sqe;
66-
sqe = io_uring_get_sqe(&machine->ring);
65+
struct io_uring_sqe *sqe = io_uring_get_sqe(&machine->ring);
6766
if (likely(sqe)) goto done;
6867

6968
um_raise_internal_error("Submission queue full. Consider raising the machine size.");
@@ -282,22 +281,22 @@ void *um_wait_for_cqe_without_gvl(void *ptr) {
282281
return NULL;
283282
}
284283

285-
inline void um_profile_wait_cqe_pre(struct um *machine, double *time_monotonic0, VALUE *fiber) {
286-
// *fiber = rb_fiber_current();
287-
*time_monotonic0 = um_get_time_monotonic();
288-
// double time_cpu = um_get_time_cpu();
289-
// double elapsed = time_cpu - machine->metrics.time_last_cpu;
290-
// um_update_fiber_time_run(fiber, time_monotonic0, elapsed);
291-
// machine->metrics.time_last_cpu = time_cpu;
292-
}
284+
// inline void um_profile_wait_cqe_pre(struct um *machine, double *time_monotonic0, VALUE *fiber) {
285+
// VALUE fiber = rb_fiber_current();
286+
// *time_monotonic0 = um_get_time_monotonic();
287+
// double time_cpu = um_get_time_cpu();
288+
// double elapsed = time_cpu - machine->metrics.time_last_cpu;
289+
// um_update_fiber_time_run(fiber, time_monotonic0, elapsed);
290+
// machine->metrics.time_last_cpu = time_cpu;
291+
// }
293292

294-
inline void um_profile_wait_cqe_post(struct um *machine, double time_monotonic0, VALUE fiber) {
295-
// double time_cpu = um_get_time_cpu();
296-
double elapsed = um_get_time_monotonic() - time_monotonic0;
297-
// um_update_fiber_last_time(fiber, cpu_time1);
298-
machine->metrics.time_total_wait += elapsed;
299-
// machine->metrics.time_last_cpu = time_cpu;
300-
}
293+
// inline void um_profile_wait_cqe_post(struct um *machine, double time_monotonic0, VALUE fiber) {
294+
// // double time_cpu = um_get_time_cpu();
295+
// double elapsed = um_get_time_monotonic() - time_monotonic0;
296+
// // um_update_fiber_last_time(fiber, cpu_time1);
297+
// machine->metrics.time_total_wait += elapsed;
298+
// // machine->metrics.time_last_cpu = time_cpu;
299+
// }
301300

302301
inline void *um_wait_for_sidecar_signal(void *ptr) {
303302
struct um *machine = ptr;
@@ -329,11 +328,11 @@ static inline void um_wait_for_and_process_ready_cqes(struct um *machine, int wa
329328
// fprintf(stderr, "<< sidecar wait cqes\n");
330329
}
331330
else {
332-
double time_monotonic0 = 0.0;
333-
VALUE fiber;
334-
if (machine->profile_mode) um_profile_wait_cqe_pre(machine, &time_monotonic0, &fiber);
331+
// double time_monotonic0 = 0.0;
332+
// VALUE fiber;
333+
// if (machine->profile_mode) um_profile_wait_cqe_pre(machine, &time_monotonic0, &fiber);
335334
rb_thread_call_without_gvl(um_wait_for_cqe_without_gvl, (void *)&ctx, RUBY_UBF_IO, 0);
336-
if (machine->profile_mode) um_profile_wait_cqe_post(machine, time_monotonic0, fiber);
335+
// if (machine->profile_mode) um_profile_wait_cqe_post(machine, time_monotonic0, fiber);
337336

338337
if (unlikely(ctx.result < 0)) {
339338
// the internal calls to (maybe submit) and wait for cqes may fail with:
@@ -357,14 +356,14 @@ static inline void um_wait_for_and_process_ready_cqes(struct um *machine, int wa
357356
}
358357
}
359358

360-
inline void um_profile_switch(struct um *machine, VALUE next_fiber) {
361-
// *current_fiber = rb_fiber_current();
362-
// double time_cpu = um_get_time_cpu();
363-
// double elapsed = time_cpu - machine->metrics.time_last_cpu;
364-
// um_update_fiber_time_run(cur_fiber, time_cpu, elapsed);
365-
// um_update_fiber_time_wait(next_fiber, time_cpu);
366-
// machine->metrics.time_last_cpu = time_cpu;
367-
}
359+
// inline void um_profile_switch(struct um *machine, VALUE next_fiber) {
360+
// VALUE current_fiber = rb_fiber_current();
361+
// double time_cpu = um_get_time_cpu();
362+
// double elapsed = time_cpu - machine->metrics.time_last_cpu;
363+
// um_update_fiber_time_run(cur_fiber, time_cpu, elapsed);
364+
// um_update_fiber_time_wait(next_fiber, time_cpu);
365+
// machine->metrics.time_last_cpu = time_cpu;
366+
// }
368367

369368
inline VALUE process_runqueue_op(struct um *machine, struct um_op *op) {
370369
DEBUG_PRINTF("* process_runqueue_op: op=%p kind=%s ref_count=%d flags=%x\n",
@@ -378,7 +377,7 @@ inline VALUE process_runqueue_op(struct um *machine, struct um_op *op) {
378377
op->flags &= ~OP_F_SCHEDULED;
379378
um_op_release(machine, op);
380379

381-
if (machine->profile_mode) um_profile_switch(machine, fiber);
380+
// if (machine->profile_mode) um_profile_switch(machine, fiber);
382381
VALUE ret = rb_fiber_transfer(fiber, 1, &value);
383382
RB_GC_GUARD(value);
384383
RB_GC_GUARD(ret);

0 commit comments

Comments
 (0)