Skip to content

Commit 5d93b2b

Browse files
committed
ci: use hashFiles(VERSION) as Envoy cache key; drop ENVOY_DEV_SHA env
Cache key is now the hash of down/abi_impl/VERSION, so make update-sdk is the single trigger that both bumps the SDK and invalidates the cached dev binary. No separate SHA to maintain.
1 parent d47f95c commit 5d93b2b

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ on:
1515

1616
env:
1717
CGO_ENABLED: "1"
18-
ENVOY_DEV_SHA: "0d6e3c60aa55e434f28e581df1d25fcb83404b68"
1918

2019
jobs:
2120
# ---------------------------------------------------------------------------
@@ -55,7 +54,8 @@ jobs:
5554

5655
# ---------------------------------------------------------------------------
5756
# e2e: all integration test suites against dev Envoy
58-
# ENVOY_DEV_SHA pins the dev build; bump it alongside the SDK when updating.
57+
# Cache key is the hash of down/abi_impl/VERSION so the binary refreshes
58+
# automatically whenever make update-sdk bumps the SDK commit.
5959
# ---------------------------------------------------------------------------
6060
e2e:
6161
name: e2e
@@ -72,7 +72,7 @@ jobs:
7272
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
7373
with:
7474
path: .bin/envoy
75-
key: envoy-dev-${{ env.ENVOY_DEV_SHA }}-linux-amd64
75+
key: envoy-dev-${{ hashFiles('down/abi_impl/VERSION') }}-linux-amd64
7676

7777
- name: download envoy
7878
if: steps.cache-envoy.outputs.cache-hit != 'true'

0 commit comments

Comments
 (0)