validate fails with commit hash

[FabienDanieau]

With the example file repos.test :

repositories:
  vcs:
    type: git
    url: https://github.com/dirk-thomas/vcstool.git
    version: daf389377310f7f31b2171f51a79af82c31bf3e2

The validate command fails

$ vcs validate --input repos.test
=== vcs (git) ===
Invocation of command 'validate' on client 'git' failed: UnboundLocalError: cannot access local variable 'version_type' where it is not associated with a value (/usr/lib/python3/dist-packages/vcstool/clients/git.py:744)

While a clone works just fine

$ vcs import --input repos.test test/
=== test/vcs (git) ===
Clonage dans '.'...
Note : basculement sur 'daf389377310f7f31b2171f51a79af82c31bf3e2'.

Note that the validate works with tags if the commit hash is changed by 0.3.0

$ vcs validate --input repos.test
=== vcs (git) ===
Found git repository 'https://github.com/dirk-thomas/vcstool.git' with tag '0.3.0'

[christophebedard]

#239 might fix this. Can you try it out? You should be able to install the version from that PR like this:

pip3 install git+https://github.com/furushchev/vcstool@fix-validate-git-hash

[FabienDanieau]

#239 might fix this. Can you try it out? You should be able to install the version from that PR like this:

pip3 install git+https://github.com/furushchev/vcstool@fix-validate-git-hash

Yes it works thank you. Any plan to merge this soon?

[christophebedard]

I don't know. vcstool is in no/low maintenance mode (see #242), so I don't know when that will get merged.

[MaxandreOgeret]

This was solved in vcstool2, my fork of vcs.

[FabienDanieau]

This was solved in vcstool2, my fork of vcs.
Thanks. Sorry for the late answer.

Actually both solutions does not raise any explicit error when a tag or the branch name is invalid. Just:

Found git repository 'git@github.com:xxx' but unable to verify non-branch / non-tag ref 'fake-branch-name' without cloning the repo

I ended up to manually check if the checkout went correctly by parsing the output: ..... or ..E... for instance