DEV: Match tag icons on the name the viewer reads

The page object located tags through `data-tag-name`, which core is
changing to carry the untranslated name so it stays stable across
locales. Asserting on the visible text instead holds either way.

Author: ZogStriP

spec/system/page_objects/components/tag_icon.rb

@@ -3,16 +3,18 @@
 module PageObjects
   module Components
     class TagIcon < PageObjects::Components::Base
+      # Tags are matched on the name the viewer reads, so these assertions hold
+      # whether or not a localization applies.
       def has_icon_for_tag?(tag_name:, icon:, color: nil)
-        selector = ".discourse-tag[data-tag-name='#{tag_name}']"
+        selector = ".discourse-tag"
         selector += "[style*='--color1: #{color}; --color2: #fffd;']" if color
-        selector += " .tag-icon .d-icon-#{icon}"
-        page.has_css?(selector)
+
+        page.has_css?("#{selector}:has(.tag-icon .d-icon-#{icon})", text: tag_name)
       end
 
       def has_no_icon_for_tag?(tag_name:)
-        page.has_css?(".discourse-tag[data-tag-name='#{tag_name}']") &&
-          page.has_no_css?(".discourse-tag[data-tag-name='#{tag_name}'] .tag-icon")
+        page.has_css?(".discourse-tag", text: tag_name) &&
+          page.has_no_css?(".discourse-tag:has(.tag-icon)", text: tag_name)
       end
     end
   end