Commit 48aea8c
committed
fix(hubfile): drop hardcoded v= from the FactLabel URL
FactLabel's JS compares the URL's ?v= against its own version.json and
redirects the page to /error_version.html (a GitHub Pages 404) when
they differ. Hardcoding v=1.8.0 worked when FactLabel was on 1.8.0; it
broke the moment they bumped to 1.8.1, which is what's live on
fmfactlabel.github.io today.
Omitting ?v= entirely skips the check (the condition is
`urlVersion && urlVersion !== officialVersion`) and lets FactLabel
work with whatever version it's currently serving. No other caller of
the FactLabel URL cares about the version parameter.1 parent b85841a commit 48aea8c
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
91 | 99 | | |
92 | 100 | | |
93 | 101 | | |
| |||
0 commit comments