Skip to content

Commit 7b1286e

Browse files
committed
Merge branch 'develop' into main
2 parents 83cfadb + 563a87c commit 7b1286e

3 files changed

Lines changed: 13 additions & 1 deletion

File tree

app/modules/generator/routes.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ def validate_step1_form(form):
9292
num_models = int(num_models_val)
9393
if num_models < 1:
9494
errors["num_models_val"] = "Number of models must be at least 1."
95+
elif num_models > 1000:
96+
errors["num_models_val"] = "Number of models cannot exceed 1000."
9597
except Exception:
9698
errors["num_models_val"] = "Number of models must be an integer."
9799

app/modules/generator/templates/generator/step1.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
{{ number_field('num_models_val', 'Number of models',
1111
'How many random feature models to generate in this batch.',
12-
values, errors, default=5, min=1) }}
12+
values, errors, default=5, min=1, max=1000) }}
1313

1414
{{ number_field('seed', 'Seed',
1515
'Random seed used to make runs reproducible. Same seed + same parameters = same models.',

app/modules/generator/tests/test_validators.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,16 @@ def test_step1_rejects_negative_seed():
6161
assert "seed" in errors
6262

6363

64+
def test_step1_rejects_num_models_over_cap():
65+
errors, _ = validate_step1_form(MultiDict({"num_models_val": "1001", "seed": "1"}))
66+
assert "num_models_val" in errors
67+
68+
69+
def test_step1_accepts_num_models_at_cap():
70+
errors, _ = validate_step1_form(MultiDict({"num_models_val": "1000", "seed": "1"}))
71+
assert "num_models_val" not in errors
72+
73+
6474
# ── step2 ─────────────────────────────────────────────────────────────────
6575

6676

0 commit comments

Comments
 (0)