fix(release): make the production Docker build and deploy work

Two splent-migration leftovers broke the tagged-release pipeline:

- app/features/webhook/services.py created `docker.from_env()` at module import.
  The rosemary CLI imports every command (and thus the app) while running
  `rosemary webpack:compile` during `docker build`, where there is no Docker
  daemon, so the release image failed to build. The client is now created
  lazily on first use.
- rosemary selenium/locust commands still branched on the old WORKING_DIR
  "/app/" (and a "/app" mount destination); updated to "/workspace" to match the
  splent layout, so those commands work inside the new containers.

Verified: the rosemary CLI now loads with no Docker daemon (37 commands) and
`docker build -f docker/images/Dockerfile.prod` succeeds end to end
(webpack:compile runs for every feature; image builds).

Author: drorganvidez

app/features/webhook/services.py

@@ -8,7 +8,22 @@
 
 import docker
 
-client = docker.from_env()
+_client = None
+
+
+def _get_client():
+    """Lazily build the Docker client on first use, not at import time.
+
+    Importing this module must not require a Docker daemon: the rosemary CLI
+    imports every command module (which pulls in the app, and therefore this
+    service) while running 'rosemary webpack:compile' during 'docker build',
+    where no daemon exists. Connecting at import broke the release image build.
+    """
+    global _client
+    if _client is None:
+        _client = docker.from_env()
+    return _client
+
 
 # Commands run inside every target container, in order, on each deploy.
 DEPLOY_COMMANDS = (
@@ -31,13 +46,13 @@ def is_authorized(self, auth_header: str | None) -> bool:
 
     def get_web_container(self):
         try:
-            return client.containers.get("web_app_container")
+            return _get_client().containers.get("web_app_container")
         except docker.errors.NotFound:
             abort(404, description="Web container not found.")
 
     def get_worker_container(self):
         try:
-            return client.containers.get("rq_worker_container")
+            return _get_client().containers.get("rq_worker_container")
         except docker.errors.NotFound:
             abort(404, description="Worker container not found.")
 

rosemary/src/rosemary/commands/locust.py

@@ -123,7 +123,7 @@ def run_vagrant_locust(module):
     if module:
         validate_module(module)
 
-    if working_dir == "/app/":
+    if working_dir == "/workspace/":
         client = docker.from_env()
 
         try:
@@ -132,7 +132,7 @@ def run_vagrant_locust(module):
                 (
                     mount.get("Name") or mount.get("Source")
                     for mount in web_container.attrs["Mounts"]
-                    if mount["Destination"] == "/app"
+                    if mount["Destination"] == "/workspace"
                 ),
                 None,
             )
@@ -180,7 +180,7 @@ def stop_docker_locust():
         # Remove the Locust container
         subprocess.run(rm_command)
 
-    if working_dir == "/app/":
+    if working_dir == "/workspace/":
         stop_docker_locust()
 
     elif working_dir == "" or working_dir == "/vagrant/":

rosemary/src/rosemary/commands/selenium.py

@@ -83,7 +83,7 @@ def run_vagrant_tests(module_name):
         if module:
             validate_module(module)
 
-        if working_dir == "/app/":
+        if working_dir == "/workspace/":
             run_selenium_tests(module, env="docker")
         elif working_dir == "":
             run_selenium_tests(module, env="local")