Skip to content

Commit 85169f0

Browse files
authored
Apply suggestions from code review
1 parent cc8574d commit 85169f0

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

rules-threat-hunting/windows/builtin/appxdeployment_server/win_appxpackaging_server_successful_package_installation.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ logsource:
1919
detection:
2020
selection:
2121
EventID: 854
22-
filter_optional_x_windowsupdate:
23-
Path|contains: 'x-windowsupdate://'
24-
condition: selection and not 1 of filter_optional_*
22+
condition: selection
2523
falsepositives:
2624
- Legitimate MSIX/AppX package installations
2725
level: low

rules/windows/builtin/bits_client/win_bits_client_new_transfer_via_uncommon_tld.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ references:
77
- https://twitter.com/malmoeb/status/1535142803075960832
88
author: Florian Roth (Nextron Systems)
99
date: 2022-06-10
10-
modified: 2024-12-25
10+
modified: 2025-02-28
1111
tags:
1212
- attack.defense-evasion
1313
- attack.persistence
@@ -26,7 +26,7 @@ detection:
2626
- 'download.mozilla.org/' # https://download.mozilla.org/?product=firefox-101.0.1-partial-101.0&os=win64&lang=en-US
2727
- 'cdn.onenote.net/'
2828
- 'cdn.office.net/'
29-
- 'tscdn.m365.static.microsoft'
29+
- 'tscdn.m365.static.microsoft/'
3030
condition: selection and not 1 of filter_main_*
3131
falsepositives:
3232
- This rule doesn't exclude other known TLDs such as ".org" or ".net". It's recommended to apply additional filters for software and scripts that leverage the BITS service

rules/windows/builtin/code_integrity/win_codeintegrity_attempted_dll_load.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ references:
1111
- https://learn.microsoft.com/en-us/windows/security/application-security/application-control/windows-defender-application-control/operations/event-id-explanations
1212
author: Florian Roth (Nextron Systems), Nasreddine Bencherchali (Nextron Systems)
1313
date: 2022-01-20
14-
modified: 2024-12-25
14+
modified: 2025-02-28
1515
tags:
1616
- attack.execution
1717
logsource:
@@ -48,13 +48,14 @@ detection:
4848
RequestedPolicy:
4949
- 8
5050
- 12
51-
filter_optional_msoffice:
51+
filter_optional_msoffice_1:
5252
FileNameBuffer|contains: '\Microsoft Office\root\vfs\ProgramFilesCommonX64\Microsoft Shared\OFFICE'
5353
FileNameBuffer|endswith: '\MSOXMLMF.DLL'
5454
# ProcessNameBuffer is AV products
5555
RequestedPolicy: 7
5656
filter_optional_msoffice_2:
57-
ProcessNameBuffer|contains: 'Program Files\Microsoft Office\root\vfs\ProgramFilesCommonX64\Microsoft Shared\Office'
57+
ProcessNameBuffer|contains: '\Program Files\Microsoft Office\root\vfs\ProgramFilesCommonX64\Microsoft Shared\Office'
58+
FileNameBuffer|contains: '\Windows\System32\'
5859
RequestedPolicy: 8
5960
filter_optional_slack:
6061
# Example: https://user-images.githubusercontent.com/112784902/197407680-96d4b662-8a59-4289-a483-b24d630ac2a9.png

0 commit comments

Comments
 (0)