review: add intentional-5-speeds comment; rename misleading tests

- Add inline comment at the speeds == 3 branch explaining that
  3-speed-reporting units under-report their capability and
  intentionally receive the full 5-speed list.
- Rename test_set_fan_speed_accepts_superquiet_on_3speed →
  test_get_fan_speeds_includes_superquiet_on_3speed and
  test_set_fan_speed_accepts_superpowerful_on_3speed →
  test_get_fan_speeds_includes_superpowerful_on_3speed.
  These tests assert get_fan_speeds() membership, not set_fan_speed()
  behaviour; rename + docstring fix makes that accurate.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: d-walsh

pykumo/py_kumo.py

@@ -389,6 +389,10 @@ def get_fan_speeds(self):
             )
 
         if speeds == 3:
+            # Intentionally return all 5 speeds even though the profile reports
+            # numberOfFanSpeeds=3.  These units under-report their capability:
+            # real hardware accepts the full superQuiet..superPowerful range,
+            # as confirmed on units in the field.
             valid_speeds = ["superQuiet", "quiet", "low", "powerful", "superPowerful"]
         elif speeds == 4:
             valid_speeds = ["quiet", "Low", "powerful", "superPowerful"]

tests/test_fan_speeds.py

@@ -62,17 +62,17 @@ def test_5speed_unchanged(self):
             speeds, ["superQuiet", "quiet", "low", "powerful", "superPowerful"]
         )
 
-    def test_set_fan_speed_accepts_superquiet_on_3speed(self):
-        """set_fan_speed must accept superQuiet for 3-speed units."""
+    def test_get_fan_speeds_includes_superquiet_on_3speed(self):
+        """get_fan_speeds() must include superQuiet for 3-speed units."""
         with patch.object(PyKumo, "__init__", lambda self, *a, **kw: None):
             unit = PyKumo.__new__(PyKumo)
         unit._profile = {"numberOfFanSpeeds": 3}
         unit._status = {}
         valid = unit.get_fan_speeds()
         self.assertIn("superQuiet", valid)
 
-    def test_set_fan_speed_accepts_superpowerful_on_3speed(self):
-        """set_fan_speed must accept superPowerful for 3-speed units."""
+    def test_get_fan_speeds_includes_superpowerful_on_3speed(self):
+        """get_fan_speeds() must include superPowerful for 3-speed units."""
         with patch.object(PyKumo, "__init__", lambda self, *a, **kw: None):
             unit = PyKumo.__new__(PyKumo)
         unit._profile = {"numberOfFanSpeeds": 3}