refactor(cli): rename validation-errors to arg-errors

`validation-errors` collided with the env-graph's own ValidationError, which is about
config item values failing their schema and is part of the public API. This module is
about the CLI arguments themselves, so name it for that. `isArgValidationError` becomes
`isArgError` for the same reason.

Author: theoephraim

packages/varlock/src/cli/cli-executable.ts

@@ -10,7 +10,7 @@ import { CliExitError } from './helpers/exit-error';
 import { fmt } from './helpers/pretty-format';
 import { trackCommand, trackInstall } from './helpers/telemetry';
 import { InvalidEnvError } from './helpers/error-checks';
-import { isArgValidationError, toCliExitError } from './helpers/validation-errors';
+import { isArgError, toCliExitError } from './helpers/arg-errors';
 import { checkBunVersion } from '../lib/check-bun-version';
 import { checkLocalVersionMismatch } from '../lib/check-local-version';
 import packageJson from '../../package.json';
@@ -159,7 +159,7 @@ subCommands.set('proxy', buildLazyCommand(proxyCommandSpec, async () => await im
     }
     gracefulExit();
   } catch (error) {
-    if (isArgValidationError(error)) {
+    if (isArgError(error)) {
       console.error(toCliExitError(error, process.argv.slice(2)).getFormattedOutput());
     } else if (error instanceof Error && error.message.startsWith('Command not found: ')) {
       const badCommandName = error.message.split(': ')[1];

…ock/src/cli/helpers/validation-errors.ts …es/varlock/src/cli/helpers/arg-errors.tspackages/varlock/src/cli/helpers/validation-errors.ts renamed to packages/varlock/src/cli/helpers/arg-errors.ts packages/varlock/src/cli/helpers/validation-errors.ts renamed to packages/varlock/src/cli/helpers/arg-errors.ts

@@ -1,6 +1,9 @@
 import { CliExitError } from './exit-error';
 import { fmt } from './pretty-format';
 
+// Errors about the CLI arguments themselves - unrelated to the env-graph's ValidationError,
+// which is about config item values failing their schema.
+//
 // gunshi reports argument problems (unknown options under `strict`, bad enum/type values,
 // unresolvable subcommands) as an AggregateError of structured errors, and renders them
 // with `ctx.log` - i.e. stdout, which would corrupt the output of commands like
@@ -99,8 +102,8 @@ export function commandPathFromArgs(args: Array<string>) {
   return path;
 }
 
-/** Does this error (or aggregate) come from gunshi's argument validation? */
-export function isArgValidationError(err: unknown): err is AggregateError {
+/** Does this error come from gunshi's argument parsing (unknown flag/command, bad value)? */
+export function isArgError(err: unknown): err is AggregateError {
   return err instanceof AggregateError && Array.isArray(err.errors);
 }
 

…i/helpers/test/validation-errors.test.ts …/src/cli/helpers/test/arg-errors.test.tspackages/varlock/src/cli/helpers/test/validation-errors.test.ts renamed to packages/varlock/src/cli/helpers/test/arg-errors.test.ts packages/varlock/src/cli/helpers/test/validation-errors.test.ts renamed to packages/varlock/src/cli/helpers/test/arg-errors.test.ts

@@ -3,9 +3,9 @@ import {
   levenshtein,
   suggestClosest,
   commandPathFromArgs,
-  isArgValidationError,
+  isArgError,
   toCliExitError,
-} from '../validation-errors';
+} from '../arg-errors';
 
 /** Shape of gunshi's unknown-option error (matched structurally, never by instanceof) */
 const unknownOption = (rawName: string, candidates: Array<string>) => ({
@@ -64,11 +64,11 @@ describe('commandPathFromArgs', () => {
   });
 });
 
-describe('isArgValidationError', () => {
+describe('isArgError', () => {
   it('only matches an AggregateError', () => {
-    expect(isArgValidationError(new AggregateError([]))).toBe(true);
-    expect(isArgValidationError(new Error('boom'))).toBe(false);
-    expect(isArgValidationError(undefined)).toBe(false);
+    expect(isArgError(new AggregateError([]))).toBe(true);
+    expect(isArgError(new Error('boom'))).toBe(false);
+    expect(isArgError(undefined)).toBe(false);
   });
 });