Replace urls with cmsweb only endpoints (no cmsweb-prod), for WMAgent.#12431
Open
khurtado wants to merge 2 commits intodmwm:masterfrom
Open
Replace urls with cmsweb only endpoints (no cmsweb-prod), for WMAgent.#12431khurtado wants to merge 2 commits intodmwm:masterfrom
khurtado wants to merge 2 commits intodmwm:masterfrom
Conversation
|
Jenkins results:
|
|
Jenkins results:
|
Contributor
|
test this please |
|
Jenkins results:
|
This was referenced Sep 2, 2025
Contributor
Author
|
test this please |
|
Jenkins results:
|
Contributor
Author
|
test this please |
|
Jenkins results:
|
Contributor
Author
|
test this please |
amaltaro
reviewed
Sep 2, 2025
Contributor
amaltaro
left a comment
amaltaro
left a comment
There was a problem hiding this comment.
@khurtado I tried to highlight which modules are important to update (along the code).
Most of the test/*, src/python/WMQuality and mocking stuff is irrelevant - as we are not planning to merge these changes.
I would suggest to make an explicity replacement back from cmsweb-prod to cmsweb - as workflow specs are supposed to be set as cmsweb-prod in ReqMgr2 (which propagates down into the system).
| self.config = config | ||
| dbsUrl = "https://cmsweb-prod.cern.ch/dbs/prod/global/DBSReader" | ||
| #dbsUrl = "https://cmsweb-prod.cern.ch/dbs/prod/global/DBSReader" | ||
| dbsUrl = "https://cmsweb.cern.ch/dbs/prod/global/DBSReader" |
| try: | ||
| self.dbsURL = url.replace("cmsweb.cern.ch", "cmsweb-prod.cern.ch") | ||
| #self.dbsURL = url.replace("cmsweb.cern.ch", "cmsweb-prod.cern.ch") | ||
| self.dbsURL = url |
Contributor
There was a problem hiding this comment.
And maybe we should check like:
if cmsweb-prod.cern.ch:
then set cmsweb.cern.ch
Contributor
Author
There was a problem hiding this comment.
Good point, I am doing the inverse replacement now
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
Contributor
Author
|
@amaltaro Thanks! I made the changes to force replace from cmsweb-prod to cmsweb in the files you pointed out. |
|
Jenkins results:
|
khurtado
force-pushed
the
noprod
branch
2 times, most recently
from
38e0f6f to
6f6938b
Compare
Fix bug in previous commit. Explicitly force change from cmsweb-prod to cmsweb
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
Contributor
|
test this please |
|
Jenkins results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12429
Status
not-tested
Description
Test running agent with cmsweb endpoints only
Is it backward compatible (if not, which system it affects?)
YES