WIP: return early on error, and don't save

thaJeztah · thaJeztah · commit 0920f1b25905 · 2026-01-26T18:34:28.000+01:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go
@@ -168,7 +168,7 @@ func loginWithStoredCredentials(ctx context.Context, dockerCLI command.Cli, auth
 		} else {
 			_, _ = fmt.Fprintln(dockerCLI.Err(), "Login did not succeed, error:", err)
 		}
-		// TODO(thaJeztah): should this return the error here, or is there a reason for continuing?
+		return err
 	}
 
 	if resp.Auth.IdentityToken != "" {

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ func loginWithStoredCredentials(ctx context.Context, dockerCLI command.Cli, auth`
`168`	`168`	`} else {`
`169`	`169`	`_, _ = fmt.Fprintln(dockerCLI.Err(), "Login did not succeed, error:", err)`
`170`	`170`	`}`
`171`		`- // TODO(thaJeztah): should this return the error here, or is there a reason for continuing?`
	`171`	`+ return err`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`if resp.Auth.IdentityToken != "" {`