fix: defend custom attribute resolution against PHP 8.1 exceptions (#481)

* fix: catch PHP 8.1 deprecation exceptions in custom attribute resolution

* fix: split try/catch blocks and narrow to Exception in attribute resolution

* style: fix PHPCS indentation in Product.php catch blocks

Author: juaniten

Doofinder/Feed/Helper/Product.php

@@ -414,9 +414,33 @@ public function getAttributeType(ProductModel $product, string $attributeCode):
             return null;
         }
         $frontend = $attribute->getFrontend();
-        $value = $frontend->getOption($optionId);
+        try {
+            $value = $frontend->getOption($optionId);
+        } catch (\Exception $e) {
+            $this->_logger->warning(
+                sprintf(
+                    'Doofinder: could not resolve type for attribute "%s": %s',
+                    $attributeCode,
+                    $e->getMessage()
+                ),
+                ['product_id' => $product->getId()]
+            );
+            return null;
+        }
         if (!$value) {
-            $value = $frontend->getValue($product);
+            try {
+                $value = $frontend->getValue($product);
+            } catch (\Exception $e) {
+                $this->_logger->warning(
+                    sprintf(
+                        'Doofinder: could not resolve type for attribute "%s": %s',
+                        $attributeCode,
+                        $e->getMessage()
+                    ),
+                    ['product_id' => $product->getId()]
+                );
+                return null;
+            }
         }
 
         return get_debug_type($value);
@@ -441,9 +465,33 @@ public function getAttribute(ProductModel $product, string $attributeCode)
             return null;
         }
         $frontend = $attribute->getFrontend();
-        $value = $frontend->getOption($optionId);
+        try {
+            $value = $frontend->getOption($optionId);
+        } catch (\Exception $e) {
+            $this->_logger->warning(
+                sprintf(
+                    'Doofinder: could not resolve value for attribute "%s": %s',
+                    $attributeCode,
+                    $e->getMessage()
+                ),
+                ['product_id' => $product->getId()]
+            );
+            return null;
+        }
         if (!$value) {
-            $value = $frontend->getValue($product);
+            try {
+                $value = $frontend->getValue($product);
+            } catch (\Exception $e) {
+                $this->_logger->warning(
+                    sprintf(
+                        'Doofinder: could not resolve value for attribute "%s": %s',
+                        $attributeCode,
+                        $e->getMessage()
+                    ),
+                    ['product_id' => $product->getId()]
+                );
+                return null;
+            }
         }
         if (is_a($value, Phrase::class)) {
             $value = $value->render();

Doofinder/Feed/composer.json

@@ -1,6 +1,6 @@
 {
   "name": "doofinder/doofinder-magento2",
-  "version": "1.7.3",
+  "version": "1.7.4",
   "description": "Doofinder module for Magento 2",
   "type": "magento2-module",
   "require": {

Doofinder/Feed/etc/module.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Doofinder_Feed" setup_version="1.7.3">
+    <module name="Doofinder_Feed" setup_version="1.7.4">
         <sequence>
             <module name="Magento_Integration" />
         </sequence>