Ensuring typedefs to all kinds of arrays work as expected (#124)

tannergooding · web-flow · commit 2126c1f2a407 · 2020-04-16T14:37:15.000-07:00
diff --git a/sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitDecl.cs b/sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitDecl.cs
@@ -1735,7 +1735,7 @@ private void VisitTypedefDeclForUnderlyingType(TypedefDecl typedefDecl, Type und
             {
                 VisitTypedefDeclForUnderlyingType(typedefDecl, typedefType.Decl.UnderlyingType);
             }
-            else if (!(underlyingType is BuiltinType) && !(underlyingType is IncompleteArrayType) && !(underlyingType is TagType))
+            else if (!(underlyingType is ArrayType) && !(underlyingType is BuiltinType) && !(underlyingType is TagType))
             {
                 AddDiagnostic(DiagnosticLevel.Error, $"Unsupported underlying type: '{underlyingType.TypeClass}'. Generating bindings may be incomplete.", typedefDecl);
             }

Original file line number	Diff line number	Diff line change
`@@ -1735,7 +1735,7 @@ private void VisitTypedefDeclForUnderlyingType(TypedefDecl typedefDecl, Type und`
`1735`	`1735`	`{`
`1736`	`1736`	`VisitTypedefDeclForUnderlyingType(typedefDecl, typedefType.Decl.UnderlyingType);`
`1737`	`1737`	`}`
`1738`		`- else if (!(underlyingType is BuiltinType) && !(underlyingType is IncompleteArrayType) && !(underlyingType is TagType))`
	`1738`	`+ else if (!(underlyingType is ArrayType) && !(underlyingType is BuiltinType) && !(underlyingType is TagType))`
`1739`	`1739`	`{`
`1740`	`1740`	`AddDiagnostic(DiagnosticLevel.Error, $"Unsupported underlying type: '{underlyingType.TypeClass}'. Generating bindings may be incomplete.", typedefDecl);`
`1741`	`1741`	`}`