Add failure label to AutoBuilder - Failed notifications for recent build failures

The failure label was only added when an exception was thrown, not when the
category was 'Failed' due to recent build failures. This caused these
actionable issues to be immediately closed by NotificationService.

Change the condition from `exception is not null` to `category == "Failed"`
so both failure paths (exception and recent failed builds) get the failure
label and remain open.

Agent-Logs-Url: https://github.com/dotnet/docker-tools/sessions/89cbb121-4c87-422e-83ec-09a65bd377c6

Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>

Author: Copilot

src/ImageBuilder.Tests/QueueBuildCommandTests.cs

@@ -116,6 +116,51 @@ public async Task QueueBuildCommand_RecentFailedBuilds_MaxFailed()
             context.Verify(notificationPostCallCount: 1, isQueuedBuildExpected: false);
         }
 
+        /// <summary>
+        /// Verifies that the failure label is included in the notification when there are too many recent failed builds.
+        /// </summary>
+        [Fact]
+        public async Task QueueBuildCommand_RecentFailedBuilds_IncludesFailureLabel()
+        {
+            const string path1 = "path1";
+
+            Subscription[] subscriptions = new Subscription[]
+            {
+                CreateSubscription("repo1")
+            };
+
+            List<List<SubscriptionImagePaths>> allSubscriptionImagePaths = new()
+            {
+                new List<SubscriptionImagePaths>
+                {
+                    new SubscriptionImagePaths
+                    {
+                        SubscriptionId = subscriptions[0].Id,
+                        ImagePaths = new string[]
+                        {
+                            path1
+                        }
+                    }
+                }
+            };
+
+            PagedList<WebApi.Build> allBuilds = new();
+
+            for (int i = 0; i < QueueBuildCommand.BuildFailureLimit; i++)
+            {
+                WebApi.Build failedBuild = CreateBuild($"https://failedbuild-{i}");
+                failedBuild.Tags.Add(AzdoTags.AutoBuilder);
+                failedBuild.Status = WebApi.BuildStatus.Completed;
+                failedBuild.Result = WebApi.BuildResult.Failed;
+                allBuilds.Add(failedBuild);
+            }
+
+            using TestContext context = new(subscriptions, allSubscriptionImagePaths, new PagedList<WebApi.Build>(), allBuilds);
+            await context.ExecuteCommandAsync();
+
+            context.VerifyNotificationLabelsContain(NotificationLabels.Failure);
+        }
+
         /// <summary>
         /// Verifies that a build is queued even if there are recent failed builds but not enough to meet the threshold.
         /// </summary>
@@ -588,6 +633,20 @@ public void Verify(int notificationPostCallCount, bool isQueuedBuildExpected, ID
                 }
             }
 
+            public void VerifyNotificationLabelsContain(string expectedLabel)
+            {
+                _notificationServiceMock
+                    .Verify(o => o.PostAsync(
+                            It.IsAny<string>(),
+                            It.IsAny<string>(),
+                            It.Is<IEnumerable<string>>(labels => labels.Contains(expectedLabel)),
+                            It.IsAny<string>(),
+                            It.IsAny<string>(),
+                            It.IsAny<GitHubAuthOptions>(),
+                            It.IsAny<bool>(),
+                            It.IsAny<IEnumerable<string>>()));
+            }
+
             private string SerializeJsonObjectToTempFile(object jsonObject)
             {
                 string path = Path.GetTempFileName();

src/ImageBuilder/Commands/QueueBuildCommand.cs

@@ -270,7 +270,7 @@ await _notificationService.PostAsync(
                     {
                         NotificationLabels.AutoBuilder,
                         NotificationLabels.GetRepoLocationLabel(subscription.Manifest.Repo, subscription.Manifest.Branch)
-                    }.AppendIf(NotificationLabels.Failure, () => exception is not null),
+                    }.AppendIf(NotificationLabels.Failure, () => category == "Failed"),
                     Options.GitOptions.Owner,
                     Options.GitOptions.Repo,
                     Options.GitOptions.GitHubAuthOptions,