Skip to content

Commit 9123119

Browse files
rolfbjarneCopilot
andcommitted
Change DtdProcessing.Prohibit to DtdProcessing.Ignore
DtdProcessing.Prohibit throws on any DOCTYPE. Use DtdProcessing.Ignore instead to accept DOCTYPE while still preventing DTD processing and entity expansion (XmlResolver remains null). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 185a42d commit 9123119

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/bgen/Extensions/ExtensionMethods.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public static void LoadWithoutNetworkAccess (this XmlDocument doc, string filena
2525
using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read)) {
2626
var settings = new XmlReaderSettings () {
2727
XmlResolver = null,
28-
DtdProcessing = DtdProcessing.Prohibit,
28+
DtdProcessing = DtdProcessing.Ignore,
2929
};
3030
using (var reader = XmlReader.Create (fs, settings)) {
3131
doc.Load (reader);

tests/cecil-tests/Helper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ public static void LoadWithoutNetworkAccess (this XmlDocument doc, string filena
616616
using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read)) {
617617
var settings = new XmlReaderSettings () {
618618
XmlResolver = null,
619-
DtdProcessing = DtdProcessing.Prohibit,
619+
DtdProcessing = DtdProcessing.Ignore,
620620
};
621621
using (var reader = XmlReader.Create (fs, settings)) {
622622
doc.Load (reader);

tests/common/ProductTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public void MonoVersion ()
1818
// Verify that the mono version is in the Versions.plist, and that it's a parsable version number.
1919
var settings = new XmlReaderSettings () {
2020
XmlResolver = null,
21-
DtdProcessing = DtdProcessing.Prohibit
21+
DtdProcessing = DtdProcessing.Ignore
2222
};
2323

2424
var plist = Path.Combine (Configuration.SdkRoot, "Versions.plist");

tests/mtouch/MTouch.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1986,7 +1986,7 @@ static void LoadWithoutNetworkAccess (XmlDocument doc, string filename)
19861986
using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read)) {
19871987
var settings = new XmlReaderSettings () {
19881988
XmlResolver = null,
1989-
DtdProcessing = DtdProcessing.Prohibit,
1989+
DtdProcessing = DtdProcessing.Ignore,
19901990
};
19911991
using (var reader = XmlReader.Create (fs, settings)) {
19921992
doc.Load (reader);

tools/common/PListExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public static void LoadWithoutNetworkAccess (this XmlDocument doc, string filena
1111
using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read)) {
1212
var settings = new XmlReaderSettings () {
1313
XmlResolver = null,
14-
DtdProcessing = DtdProcessing.Prohibit,
14+
DtdProcessing = DtdProcessing.Ignore,
1515
};
1616
using (var reader = XmlReader.Create (fs, settings)) {
1717
doc.Load (reader);
@@ -24,7 +24,7 @@ public static void LoadXmlWithoutNetworkAccess (this XmlDocument doc, string xml
2424
using (var fs = new StringReader (xml)) {
2525
var settings = new XmlReaderSettings () {
2626
XmlResolver = null,
27-
DtdProcessing = DtdProcessing.Prohibit,
27+
DtdProcessing = DtdProcessing.Ignore,
2828
};
2929
using (var reader = XmlReader.Create (fs, settings)) {
3030
doc.Load (reader);

0 commit comments

Comments
 (0)