Commit 043a558
Name the validated platform in a fix PR title
A human reviewer rejected PR 509 partly on its title: it read "Fix for
#35667 - [Android, iOS, Catalyst] TextTransform.Uppercase does not work on
Shell SearchHandler" while the change and its test cover iOS alone. The
platforms come from the reporter's own title, quoted verbatim after "Fix
for", which reads as a claim to have fixed all three.
The body was never wrong: it states the validated platform, the exact test
and four control arms at 3/3. But the body is not what a reader sees in a
PR list, and this function's own contract already says a title "may only
promise what the diff actually contains" - the reason it refuses to say
"fix" for a reproduction-only PR. Platform is the same promise.
The reproduction branch already tags the platform; only the fix branch
dropped it, though it takes $Platform as a mandatory parameter. So this
tags it too: [maui-bot-fix][ios] Fix for #N - <title>. [maui-bot-fix]
stays first because that is the filter the reviewing human uses. The
reporter's title is still quoted verbatim - rewriting it would misdescribe
the issue - and the summary budget shrinks with the longer prefix, so the
bound holds.
5 of 42 open fix PRs inherit a multi-platform tag this way.
Nothing consumes the title format: duplicates are matched on the
MAUI_COPILOT_REPLICATION body marker, not the title.
Mutation-tested. Dropping the tag and putting it ahead of [maui-bot-fix]
are both killed, the latter only by the filter-position test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 735ac9a2-7bec-4baa-ad19-c298e5bc795a1 parent dacd4e7 commit 043a558
2 files changed
Lines changed: 76 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
938 | 938 | | |
939 | 939 | | |
940 | 940 | | |
941 | | - | |
| 941 | + | |
942 | 942 | | |
943 | 943 | | |
944 | 944 | | |
| |||
962 | 962 | | |
963 | 963 | | |
964 | 964 | | |
965 | | - | |
| 965 | + | |
966 | 966 | | |
967 | 967 | | |
968 | 968 | | |
969 | 969 | | |
970 | | - | |
| 970 | + | |
971 | 971 | | |
972 | 972 | | |
973 | 973 | | |
| |||
978 | 978 | | |
979 | 979 | | |
980 | 980 | | |
981 | | - | |
| 981 | + | |
982 | 982 | | |
983 | 983 | | |
984 | 984 | | |
| |||
987 | 987 | | |
988 | 988 | | |
989 | 989 | | |
990 | | - | |
| 990 | + | |
991 | 991 | | |
992 | 992 | | |
993 | 993 | | |
| |||
1008 | 1008 | | |
1009 | 1009 | | |
1010 | 1010 | | |
1011 | | - | |
| 1011 | + | |
1012 | 1012 | | |
1013 | 1013 | | |
1014 | 1014 | | |
| |||
1018 | 1018 | | |
1019 | 1019 | | |
1020 | 1020 | | |
1021 | | - | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
1022 | 1072 | | |
1023 | 1073 | | |
1024 | 1074 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
580 | | - | |
581 | | - | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
582 | 583 | | |
583 | 584 | | |
584 | 585 | | |
585 | 586 | | |
586 | 587 | | |
587 | 588 | | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
588 | 602 | | |
589 | 603 | | |
590 | 604 | | |
| |||
615 | 629 | | |
616 | 630 | | |
617 | 631 | | |
618 | | - | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
619 | 635 | | |
620 | 636 | | |
621 | 637 | | |
| |||
0 commit comments