Skip to content

Commit e2ea88d

Browse files
author
Copilot CI
committed
Address release approval review feedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d00747b7-96f3-4e7a-8dfb-e3a48db04b2d
1 parent d9ddcac commit e2ea88d

3 files changed

Lines changed: 11 additions & 8 deletions

File tree

.github/skills/release-readiness/references/methodology.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ Use the manual path when Arcade cannot apply the change cleanly. It is also avai
148148
For a normal automation conflict, use the source PR's **merge commit** — not its head-branch tip:
149149

150150
```bash
151-
git fetch origin
151+
git fetch <dotnet-maui-upstream-remote>
152152
git switch -c release-agent/backport-pr-<source-pr>-to-sr<N> \
153-
origin/release/<major>.0.1xx-sr<N>
153+
<dotnet-maui-upstream-remote>/release/<major>.0.1xx-sr<N>
154154
git cherry-pick -x <source-merge-sha>
155155
# Resolve any conflicts, then test the resolved behavior.
156156
git push -u <authenticated-user-fork-remote> HEAD

.github/skills/release-readiness/tests/Test-ReleaseAgentHumanApproval.ps1

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,13 @@ try {
160160
}
161161
Assert-Equal 'malformed review data fails closed' $true $malformedFailedClosed
162162

163+
$workflowPath = Join-Path $PSScriptRoot '../../../workflows/release-agent-human-approval.yml'
164+
$workflow = Get-Content -LiteralPath $workflowPath -Raw
165+
Assert-Equal 'workflow never creates the repository tracking label' $false `
166+
$workflow.Contains('gh api --method POST "repos/$REPOSITORY/labels"')
167+
Assert-Equal 'workflow fails closed when the tracking label is missing' $true `
168+
$workflow.Contains("::error::Required repository label '`$TRACKING_LABEL' is missing")
169+
163170
Write-Host "`nPassed: $script:passed Failed: $script:failed" `
164171
-ForegroundColor $(if ($script:failed -eq 0) { 'Green' } else { 'Red' })
165172
exit $(if ($script:failed -eq 0) { 0 } else { 1 })

.github/workflows/release-agent-human-approval.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,8 @@ jobs:
6666
fi
6767
6868
if ! gh api "repos/$REPOSITORY/labels/$TRACKING_LABEL" >/dev/null 2>&1; then
69-
gh api --method POST "repos/$REPOSITORY/labels" \
70-
-f name="$TRACKING_LABEL" \
71-
-f color="8250df" \
72-
-f description="Durable provenance for release-agent human approval" \
73-
>/dev/null 2>&1 ||
74-
gh api "repos/$REPOSITORY/labels/$TRACKING_LABEL" >/dev/null
69+
echo "::error::Required repository label '$TRACKING_LABEL' is missing; an administrator must pre-create it."
70+
exit 1
7571
fi
7672
7773
gh api --paginate \

0 commit comments

Comments
 (0)