Avoid double newlines when appending to a file (#14)

Author: timriley

lib/dry/files.rb

@@ -933,6 +933,8 @@ def initialize(name, opening, closing)
     # @since 0.1.0
     # @api private
     def newline(line = nil)
+      return line if line.to_s.end_with?(NEW_LINE)
+
       "#{line}#{NEW_LINE}"
     end
 

spec/integration/dry/files_spec.rb

@@ -494,10 +494,26 @@ class Append
       expect(path).to have_content(expected)
     end
 
-    # This gem was originally extracted from hanami-utils, into dry-cli,
-    # and finally into dry-files.
-    #
-    # https://github.com/hanami/utils/issues/348
+    it "does not add multiple newlines to the bottom of the file" do
+      path = root.join("append.rb")
+      content = <<~CONTENT
+        class Append
+        end
+      CONTENT
+
+      subject.write(path, content)
+      subject.append(path, "#{newline}Foo.register Append\n")
+
+      expected = <<~CONTENT
+        class Append
+        end
+
+        Foo.register Append
+      CONTENT
+
+      expect(path).to have_content(expected)
+    end
+
     it "adds a line at the bottom of a file that doesn't end with a newline" do
       path = root.join("append_missing_newline.rb")
       content = "root to: 'home#index'"