Skip to content

Commit c863bfd

Browse files
jraymakersclaude
andauthored
Fix v1.4-andium MinGW build and v1.4.4 LTS deploy race (#60)
* Pin vcpkg commit for v1.4-andium MinGW build PR #50 pinned vcpkg to 84bab45 (OpenSSL 3.6.0) for the v1.4.4 LTS job to fix its Windows MinGW build, but left the sibling v1.4-andium job on the default vcpkg (OpenSSL 3.5.0), whose make install step is incompatible with the windows-2025 MSYS2/MinGW toolchain. Apply the same pin so v1.4-andium builds OpenSSL 3.6.0 too. The Linux side is already covered by the perl-core build prerequisite added in #50. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix v1.4.4 LTS deploy depending on the wrong build job duckdb-lts-deploy deploys the v1.4.4 artifacts but declared `needs: duckdb-stable-build` (the v1.5.3 build) instead of `needs: duckdb-lts-build`. It therefore started as soon as the stable build finished and raced the LTS build's artifact upload: on runs where the LTS build finished later, the deploy failed with "Artifact not found for name: ui-v1.4.4-extension-osx_amd64". Point it at duckdb-lts-build so it waits for the build that produces the artifacts it deploys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent eb0c816 commit c863bfd

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/MainDistributionPipeline.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ jobs:
7272
duckdb_version: v1.4-andium
7373
exclude_archs: ${{ github.repository == 'duckdb/duckdb-ui' && 'wasm_mvp;wasm_eh;wasm_threads' || 'linux_arm64;linux_amd64_musl;osx_amd64;windows_amd64_mingw;wasm_mvp;wasm_eh;wasm_threads' }}
7474
extension_name: ui
75+
vcpkg_commit: '84bab45d415d22042bd0b9081aea57f362da3f35'
7576

7677
duckdb-lts-build:
7778
name: Build UI extension for DuckDB v1.4.4 (LTS)
@@ -86,7 +87,7 @@ jobs:
8687
duckdb-lts-deploy:
8788
if: ${{ github.repository == 'duckdb/duckdb-ui' && ( startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' ) }}
8889
name: Deploy UI extension for DuckDB v1.4.4 (LTS)
89-
needs: duckdb-stable-build
90+
needs: duckdb-lts-build
9091
uses: duckdb/extension-ci-tools/.github/workflows/_extension_deploy.yml@v1.4.4
9192
secrets: inherit
9293
with:

0 commit comments

Comments
 (0)