Merge pull request #1580 from theredled/fix-tests-liipimagine-1578

Fix VichImageTypeTest failing with LiipImagine enabled

Author: garak

.github/workflows/build.yaml

@@ -98,7 +98,7 @@ jobs:
                     - php: '8.4'
                       symfony: '7.4.*'
                       dependencies: highest
-                      with_imagine: false
+                      with_imagine: true
                       with_oneupbundle: false
                       max_deprecations: 6
                     - php: '8.5'

tests/Form/Type/VichImageTypeTest.php

@@ -37,7 +37,6 @@ public static function buildViewDataProvider(): array
                     'download_uri' => 'resolved-uri',
                     'download_label' => 'download',
                     'image_uri' => null,
-                    'show_download_link' => true,
                     'value' => null,
                     'attr' => [],
                     'asset_helper' => false,
@@ -56,7 +55,6 @@ public static function buildViewDataProvider(): array
                     'object' => null,
                     'download_uri' => null,
                     'image_uri' => null,
-                    'show_download_link' => false,
                     'value' => null,
                     'attr' => [],
                     'asset_helper' => false,
@@ -76,7 +74,6 @@ public static function buildViewDataProvider(): array
                     'download_uri' => false,
                     'download_label' => 'download',
                     'image_uri' => 'resolved-uri',
-                    'show_download_link' => false,
                     'value' => null,
                     'attr' => [],
                     'asset_helper' => false,
@@ -95,7 +92,6 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
-                    'show_download_link' => true,
                     'image_uri' => 'resolved-uri',
                     'value' => null,
                     'attr' => [],
@@ -115,7 +111,6 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
-                    'show_download_link' => true,
                     'image_uri' => 'image_uri',
                     'value' => null,
                     'attr' => [],
@@ -135,7 +130,6 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
-                    'show_download_link' => true,
                     'image_uri' => 'prefix-resolved-uri',
                     'value' => null,
                     'attr' => [],
@@ -207,7 +201,6 @@ public function testLiipImagineBundleIntegration(
             'object' => $object,
             'download_uri' => 'custom-uri',
             'download_label' => 'download',
-            'show_download_link' => true,
             'image_uri' => $imagineResolvedPath,
             'value' => null,
             'attr' => [],