fix(injector): initialize nullable promoted file properties

Author: tomatotomata

src/Injector/FileInjector.php

@@ -23,6 +23,8 @@ public function injectFile(object $obj, PropertyMapping $mapping): void
 
         if (null !== $path) {
             $mapping->setFile($obj, new File($path, false));
+        } else {
+            $mapping->setFile($obj, null);
         }
     }
 }

src/Mapping/PropertyMapping.php

@@ -70,12 +70,12 @@ public function getFile(object $obj): ?File
      * Modifies the file property value for the given object.
      *
      * @param object $obj  The object
-     * @param File   $file The new file
+     * @param File|null $file The new file
      *
      * @throws \InvalidArgumentException
      * @throws \TypeError
      */
-    public function setFile(object $obj, File $file): void
+    public function setFile(object $obj, ?File $file): void
     {
         $this->writeProperty($obj, 'file', $file);
     }

tests/Fixtures/PromotedFileEntity.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Vich\UploaderBundle\Tests\Fixtures;
+
+use Symfony\Component\HttpFoundation\File\File;
+
+final class PromotedFileEntity
+{
+    public function __construct(private ?File $file = null)
+    {
+    }
+
+    public function getFile(): ?File
+    {
+        return $this->file;
+    }
+
+    public function setFile(?File $file): void
+    {
+        $this->file = $file;
+    }
+}

tests/Injector/FileInjectorTest.php

@@ -4,8 +4,10 @@
 
 use PHPUnit\Framework\MockObject\MockObject;
 use Vich\UploaderBundle\Injector\FileInjector;
+use Vich\UploaderBundle\Mapping\PropertyMapping;
 use Vich\UploaderBundle\Storage\GaufretteStorage;
 use Vich\UploaderBundle\Tests\DummyEntity;
+use Vich\UploaderBundle\Tests\Fixtures\PromotedFileEntity;
 use Vich\UploaderBundle\Tests\TestCase;
 
 /**
@@ -66,4 +68,21 @@ public function testPropertyIsNullWhenFileNamePropertyIsNull(): void
         $inject = new FileInjector($this->storage);
         $inject->injectFile($obj, $fileMapping);
     }
+
+    public function testInitializesNullablePromotedFilePropertyWhenFileNamePropertyIsNull(): void
+    {
+        $obj = (new \ReflectionClass(PromotedFileEntity::class))->newInstanceWithoutConstructor();
+        $mapping = new PropertyMapping('file', 'file_name');
+
+        $this->storage
+            ->expects(self::once())
+            ->method('resolvePath')
+            ->with($obj, 'file')
+            ->willReturn(null);
+
+        $inject = new FileInjector($this->storage);
+        $inject->injectFile($obj, $mapping);
+
+        self::assertNull($obj->getFile());
+    }
 }