fix download_label_translation_domain in view

Author: theredled

src/Form/Type/VichFileType.php

@@ -31,7 +31,7 @@ public function __construct(
         protected readonly StorageInterface $storage,
         protected readonly UploadHandler $handler,
         protected readonly PropertyMappingFactory $factory,
-        ?PropertyAccessorInterface $propertyAccessor = null
+        ?PropertyAccessorInterface $propertyAccessor = null,
     ) {
         $this->propertyAccessor = $propertyAccessor ?: PropertyAccess::createPropertyAccessor();
     }
@@ -120,9 +120,10 @@ public function buildView(FormView $view, FormInterface $form, array $options):
         $view->vars['download_uri'] = null;
         if ($options['download_uri'] && $object) {
             $view->vars['download_uri'] = $this->resolveUriOption($options['download_uri'], $object, $form);
+
             $view->vars = \array_replace(
                 $view->vars,
-                $this->resolveDownloadLabel($options['download_label'], $object, $form)
+                $this->resolveDownloadLabel($options['download_label'], $object, $form, $options)
             );
         }
 
@@ -152,7 +153,7 @@ protected function resolveUriOption(mixed $uriOption, object $object, FormInterf
         return $uriOption;
     }
 
-    protected function resolveDownloadLabel(mixed $downloadLabel, object $object, FormInterface $form): array
+    protected function resolveDownloadLabel(mixed $downloadLabel, object $object, FormInterface $form, $options): array
     {
         if (true === $downloadLabel) {
             $fieldName = $this->getFieldName($form);
@@ -182,6 +183,9 @@ protected function resolveDownloadLabel(mixed $downloadLabel, object $object, Fo
             ];
         }
 
-        return ['download_label' => $downloadLabel];
+        return [
+            'download_label' => $downloadLabel,
+            'download_label_translation_domain' => $options['download_label_translation_domain'] ?? $options['translation_domain'],
+        ];
     }
 }

src/Form/Type/VichImageType.php

@@ -86,7 +86,7 @@ public function buildView(FormView $view, FormInterface $form, array $options):
 
             $view->vars = \array_replace(
                 $view->vars,
-                $this->resolveDownloadLabel($options['download_label'], $object, $form)
+                $this->resolveDownloadLabel($options['download_label'], $object, $form, $options)
             );
 
             $view->vars['download_uri'] = $this->resolveUriOption($options['download_uri'], $object, $form);

tests/Form/Type/VichFileTypeTest.php

@@ -128,6 +128,7 @@ public static function buildViewDataProvider(): array
                 [
                     'object' => $object,
                     'download_label' => 'custom label',
+                    'download_label_translation_domain' => null,
                     'download_uri' => 'resolved-uri',
                     'value' => null,
                     'attr' => [],
@@ -174,6 +175,7 @@ public static function buildViewDataProvider(): array
                 [
                     'object' => $object,
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'download_uri' => '/download/image.jpeg',
                     'value' => null,
                     'attr' => [],
@@ -190,6 +192,7 @@ public static function buildViewDataProvider(): array
                 [
                     'object' => $object,
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'download_uri' => 'custom-uri',
                     'value' => null,
                     'attr' => [],

tests/Form/Type/VichImageTypeTest.php

@@ -36,6 +36,7 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'resolved-uri',
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'image_uri' => null,
                     'show_download_link' => true,
                     'value' => null,
@@ -75,6 +76,7 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => false,
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'image_uri' => 'resolved-uri',
                     'show_download_link' => false,
                     'value' => null,
@@ -95,6 +97,7 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'show_download_link' => true,
                     'image_uri' => 'resolved-uri',
                     'value' => null,
@@ -115,6 +118,7 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'show_download_link' => true,
                     'image_uri' => 'image_uri',
                     'value' => null,
@@ -135,6 +139,7 @@ public static function buildViewDataProvider(): array
                     'object' => $object,
                     'download_uri' => 'custom-uri',
                     'download_label' => 'download',
+                    'download_label_translation_domain' => null,
                     'show_download_link' => true,
                     'image_uri' => 'prefix-resolved-uri',
                     'value' => null,