Replies: 3 comments 2 replies
-
|
Thats a really cool idea. I will have a look at your PoC. Would you be willing to open a PR to contribute this feature? There are probably many people who would be very happy to be able to use this feature as well. I guess there are a few things necessary to nail this feature:
I can see that you already added a way to add multiple repos which is very helpful |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your feedback! First of all it would be great if you could have a look at the code. There are definitely several places which could be programmed way more elegantly than I did it by copying / pasting existing code. The next thing would be - as you mentioned - to make sure that Submodels (and Concept Descriptions) are handled correctly when being moved. Changing Registry entries is currently out of scope, which means that the Repositories have to take care of it (which is the case for BaSyx). Next things along the way:
So, let's start with the first two steps - code review and Submodel handling. Would then be willing to issue a PR. |
Beta Was this translation helpful? Give feedback.
-
|
Alright, I looked at the code you wrote. Overall it seems pretty good and functionality wise everything makes sense so far. But as you said, the most stuff is copy/paste from other places. There is plenty of code duplication that can be probably be avoided. Other than that I noticed that a few places don't use Vue's recommended way of getting elements from the HTML part. Also, I wouldn't put two stores in the same file (aasStore and aasStoreCmd). And lastly, the way you currently have multiple Repositories configured is not very modular and could cause issues in scenarios other than the docker example that you added. In my opinion, the most necessary next step would be to improve the way multiple infrastructures can be configured and how that will be leveraged in the total commander for AAS. Because when this step is implemented correctly you can basically reuse the entire AAS and Submodel List components and have no issues with Submodels and ConceptDescriptions not being resolved correctly. In order to help you with those tasks, it would be great if you could open a PR for this feature and allow code owner edits. Does that work for you? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Often, there is a need for copying or moving shells from one repository to another one. Therefore it would be great to have a "Norton Commander" like functionality in the UI.
Please find a very early and incomplete PoC here: https://github.com/wiresio/basyx-aas-web-ui
Beta Was this translation helpful? Give feedback.
All reactions