chore: simplify repository-defaults retry loop readability

Agent-Logs-Url: https://github.com/eclipse-csi/otterdog/sessions/305839ba-b0c3-4931-b989-8b5354ec0cc8

Co-authored-by: mbarbero <452625+mbarbero@users.noreply.github.com>

Author: Copilot

otterdog/providers/github/web.py

@@ -547,8 +547,10 @@ async def _goto(self, page: Page, url: str) -> None:
         Also, save a screenshot if trace logging is enabled.
         """
         status = None
-        max_attempts = self._REPO_DEFAULTS_404_RETRIES + 1
-        for attempt in range(1, max_attempts + 1):
+        max_retries = self._REPO_DEFAULTS_404_RETRIES
+        max_attempts = max_retries + 1
+        for retry_idx in range(max_retries + 1):
+            attempt = retry_idx + 1
             _logger.trace("loading page '%s'", url)
             response = await page.goto(url)
             response = unwrap(response)
@@ -557,12 +559,12 @@ async def _goto(self, page: Page, url: str) -> None:
             if response.ok:
                 break
 
-            if status == 404 and url.endswith(self._REPO_DEFAULTS_PAGE_URL) and attempt < max_attempts:
+            if status == 404 and url.endswith(self._REPO_DEFAULTS_PAGE_URL) and retry_idx < max_retries:
                 _logger.debug(
                     "loading github page '%s' returned 404 (attempt %s/%s), retrying ...",
                     url,
                     attempt,
-                    self._REPO_DEFAULTS_404_RETRIES,
+                    max_attempts,
                 )
                 await sleep(self._REPO_DEFAULTS_404_RETRY_DELAY)
                 continue