Remove add-workload and add-dt-project CLI

Both commands are superseded by `pia sync`, which covers everything they did
and fixes what they could not: they only ever appended rows, so an authorization
could be granted but never revoked or corrected, re-running one duplicated the
entry, and the database was the only record of who was authorized — nothing to
review, diff, or roll back. `sync` reconciles the whole state against a curated
file that can be code-reviewed like any other change.

Keeping them alongside `sync` would mean two sources of truth: a row added by
`add-workload` is absent from the curated file, so the next `sync` would plan to
delete it again.

DependencyTrack projects were never created by `add-dt-project` either (it only
resolved an existing one and stored its UUID), so nothing is lost there —
`pia create-dt-projects` provisions them from the same file.

Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Lukas Puehringer <lukas.puehringer@eclipse-foundation.org>

Author: lukpueh

docs/DESIGN.md

@@ -412,36 +412,6 @@ idempotent: existing projects are resolved, not recreated. Requires `--dt-url` a
 than `sync`'s VIEW_PORTFOLIO, since it creates projects); it needs no
 `PIA_DATABASE_URL`.
 
-#### `pia add-workload <ef_project_id> <url>`
-
-Registers a new workload for an Eclipse Foundation project. The workload type
-is determined by the URL:
-
-- **GitHub** (URL contains `github.com`): Parses `owner` and `repo` from the
-  URL path. Queries the GitHub API (`GET https://api.github.com/users/{owner}`)
-  to fetch the numeric `repo_owner_id`. Creates a `GitHubWorkload`.
-- **Jenkins** (URL starts with `https://ci.eclipse.org`): Uses the URL as
-  `issuer`. Creates a `JenkinsWorkload`.
-
-If the `EclipseFoundationProject` row for `ef_project_id` does not exist, it is
-created automatically.
-
-#### `pia add-dt-project <ef_project_id> <dt_url> <parent_name> <project_name>`
-
-Registers a DependencyTrack project for an Eclipse Foundation project. Looks up
-the project in DependencyTrack by name hierarchy:
-
-1. Find exactly one root project by `parent_name`.
-2. Find exactly one child project by `project_name`
-3. Store `DependencyTrackProject(name=project_name, parent_uuid=<child project UUID>)`
-
-The `dt_url` argument is the DependencyTrack base URL (e.g.
-`https://sbom.eclipse.org`). Authentication uses the `PIA_DEPENDENCY_TRACK_API_KEY`
-environment variable. The API key requires at least the `VIEW_PORTFOLIO` permission.
-
-If the `EclipseFoundationProject` row for `ef_project_id` does not exist, it is
-created automatically.
-
 ## 6. Security Considerations
 
 ### 6.1 Token Validation

pia/cli.py

@@ -4,65 +4,25 @@
 -----------
 - sync: Reconcile all project authorizations from a curated file into the
   database (create/update/delete).
-
 - create-dt-projects: Create the DependencyTrack projects referenced by a curated
   file (provisioning only; no database access).
 
-- add-workload: Register a CI/CD workload that is allowed to upload SBOMs for an
-  Eclipse Foundation project.
-
-- add-dt-project: Register a DependencyTrack project as the upload target for a
-  given Eclipse Foundation project.
-
-Usage Examples
---------------
-Reconcile All Authorizations From a Curated File:
-
+Usage Example
+-------------
     PIA_DATABASE_URL=postgresql://user:secret@localhost:5432/pia \
     PIA_DEPENDENCY_TRACK_API_KEY=<API key with VIEW_PORTFOLIO permission> \
     PIA_GITHUB_TOKEN=<optional token with public read permission for rate limit> \
         uv run pia sync projects.yaml --dt-url https://sbom.eclipse.org --dry-run
 
-Register GitHub Actions:
-
-    PIA_DATABASE_URL=postgresql://user:secret@localhost:5432/pia \
-        uv run pia add-workload eclipse-foo \
-                https://github.com/eclipse-foo/repo
-
-Register Jenkins Instance:
-
-    PIA_DATABASE_URL=postgresql://user:secret@localhost:5432/pia \
-        uv run pia add-workload eclipse-bar \
-                https://ci.eclipse.org/eclipse-bar/oidc
-
-Register DependencyTrack Project:
-
-    PIA_DATABASE_URL=postgresql://user:secret@localhost:5432/pia \
-    PIA_DEPENDENCY_TRACK_API_KEY=<API key with VIEW_PORTFOLIO permission> \
-        uv run pia add-dt-project eclipse-baz \
-                https://sbom.eclipse.org "Eclipse Baz" baz-server
-
 """
 
 import logging
 import os
-from typing import Any
-from urllib.parse import urlparse
 
 import click
-import requests
 from sqlalchemy import create_engine
 from sqlalchemy.orm import Session, sessionmaker
 
-from .models import (
-    GITHUB_BASE_URL,
-    JENKINS_ISSUER_BASE_URL,
-    DependencyTrackProject,
-    EclipseFoundationProject,
-    GitHubWorkload,
-    JenkinsWorkload,
-    Workload,
-)
 from .sync import (
     apply_plan,
     build_desired,
@@ -73,8 +33,6 @@
     validate_projects_file,
 )
 
-logger = logging.getLogger(__name__)
-
 
 @click.group()
 @click.option("-v", "--verbose", is_flag=True, help="Enable debug logging.")
@@ -91,173 +49,6 @@ def _make_session() -> Session:
     return sessionmaker(bind=engine)()
 
 
-def _get_dt_api_key() -> str:
-    key = os.environ.get("PIA_DEPENDENCY_TRACK_API_KEY")
-    if not key:
-        raise click.ClickException("PIA_DEPENDENCY_TRACK_API_KEY is not set")
-    return key
-
-
-def _create_ef_project_if_needed(session: Session, ef_project_id: str) -> None:
-    if session.get(EclipseFoundationProject, ef_project_id) is None:
-        logger.info(f"Creating EclipseFoundationProject {ef_project_id!r}")
-        session.add(EclipseFoundationProject(id=ef_project_id))
-    else:
-        logger.info(f"Using existing EclipseFoundationProject {ef_project_id!r}")
-
-
-def _fetch_github_owner_id(owner: str) -> str:
-    url = f"https://api.github.com/users/{owner}"
-    logger.info(f"Fetching GitHub owner id from {url}")
-    response = requests.get(url, headers={"Accept": "application/vnd.github+json"})
-    response.raise_for_status()
-    owner_id = str(response.json()["id"])
-    logger.info(f"GitHub owner {owner!r} has id {owner_id}")
-    return owner_id
-
-
-def _dt_find_root_project_by_name(
-    dt_url: str, name: str, api_key: str
-) -> dict[str, Any]:
-    """Look up a root DependencyTrack project by name, asserting exactly one match."""
-    url = f"{dt_url.rstrip('/')}/api/v1/project"
-    logger.info(f"Querying DependencyTrack root projects at {url} for name={name!r}")
-    response = requests.get(
-        url,
-        params={"name": name, "onlyRoot": "true"},
-        headers={"X-Api-Key": api_key, "Accept": "application/json"},
-    )
-    response.raise_for_status()
-    projects = response.json()
-    if len(projects) != 1:
-        raise click.ClickException(
-            f"Expected exactly one root DependencyTrack project named {name!r}, "
-            f"found {len(projects)}"
-        )
-    return projects[0]
-
-
-@cli.command("add-workload")
-@click.argument("ef_project_id")
-@click.argument("url")
-@click.option(
-    "--dry-run",
-    is_flag=True,
-    help="Look up data and prepare the row, but do not commit.",
-)
-def add_workload(ef_project_id: str, url: str, dry_run: bool) -> None:
-    """Register a GitHub or Jenkins workload for an Eclipse Foundation project.
-
-    URL type is determined by its value: github.com URLs create a GitHubWorkload,
-    ci.eclipse.org URLs create a JenkinsWorkload with the URL as issuer. Both are
-    matched on the URL's scheme and host. Any other URL is rejected.
-    """
-    # Fail early, before the GitHub lookup, rather than after it.
-    if not os.environ.get("PIA_DATABASE_URL"):
-        raise click.ClickException("PIA_DATABASE_URL is not set")
-
-    parsed = urlparse(url)
-    base_url = f"{parsed.scheme}://{parsed.hostname}"
-    if base_url == GITHUB_BASE_URL:
-        path_parts = parsed.path.strip("/").split("/")
-        if len(path_parts) != 2 or not all(path_parts):
-            raise click.ClickException(f"GitHub URL must include owner/repo: {url}")
-        owner, repo = path_parts[0], path_parts[1]
-        owner_id = _fetch_github_owner_id(owner)
-        workload: Workload = GitHubWorkload(
-            ef_project_id=ef_project_id,
-            repo_owner=owner,
-            repo_name=repo,
-            repo_owner_id=owner_id,
-        )
-        logger.info(
-            f"Prepared GitHubWorkload(ef_project_id={ef_project_id!r}, "
-            f"repo_owner={owner!r}, repo_name={repo!r}, repo_owner_id={owner_id})"
-        )
-    elif base_url == JENKINS_ISSUER_BASE_URL:
-        workload = JenkinsWorkload(ef_project_id=ef_project_id, issuer=url)
-        logger.info(
-            f"Prepared JenkinsWorkload(ef_project_id={ef_project_id!r}, issuer={url!r})"
-        )
-    else:
-        raise click.ClickException(
-            f"URL must be a {GITHUB_BASE_URL} repo URL or a "
-            f"{JENKINS_ISSUER_BASE_URL} issuer URL: {url}"
-        )
-
-    with _make_session() as session:
-        _create_ef_project_if_needed(session, ef_project_id)
-        session.add(workload)
-        if dry_run:
-            logger.info("Dry-run: rolling back transaction")
-            session.rollback()
-        else:
-            session.commit()
-            logger.info("Committed workload")
-
-
-@cli.command("add-dt-project")
-@click.argument("ef_project_id")
-@click.argument("dt_url")
-@click.argument("parent_name")
-@click.argument("project_name")
-@click.option(
-    "--dry-run",
-    is_flag=True,
-    help="Look up data and prepare the row, but do not commit.",
-)
-def add_dt_project(
-    ef_project_id: str,
-    dt_url: str,
-    parent_name: str,
-    project_name: str,
-    dry_run: bool,
-) -> None:
-    """Register a DependencyTrack project for an Eclipse Foundation project.
-
-    Fetches the root project matching PARENT_NAME (asserting exactly one), then
-    finds PROJECT_NAME among its children (asserting exactly one), and stores
-    that child's UUID.
-    """
-    # Fail early, before the DependencyTrack lookups, rather than after them.
-    if not os.environ.get("PIA_DATABASE_URL"):
-        raise click.ClickException("PIA_DATABASE_URL is not set")
-
-    api_key = _get_dt_api_key()
-
-    parent = _dt_find_root_project_by_name(dt_url, parent_name, api_key)
-    logger.info(f"Resolved parent {parent_name!r} -> uuid={parent['uuid']}")
-
-    children = [c for c in parent.get("children", []) if c.get("name") == project_name]
-    if len(children) != 1:
-        raise click.ClickException(
-            f"Expected exactly one child named {project_name!r} under {parent_name!r}, "
-            f"found {len(children)}"
-        )
-    child_uuid = children[0]["uuid"]
-    logger.info(f"Resolved child {project_name!r} -> uuid={child_uuid}")
-
-    dt_project = DependencyTrackProject(
-        ef_project_id=ef_project_id,
-        name=project_name,
-        parent_uuid=child_uuid,
-    )
-    logger.info(
-        f"Prepared DependencyTrackProject(ef_project_id={ef_project_id!r}, "
-        f"name={project_name!r}, parent_uuid={child_uuid})"
-    )
-
-    with _make_session() as session:
-        _create_ef_project_if_needed(session, ef_project_id)
-        session.add(dt_project)
-        if dry_run:
-            logger.info("Dry-run: rolling back transaction")
-            session.rollback()
-        else:
-            session.commit()
-            logger.info("Committed DependencyTrack project")
-
-
 @cli.command("sync")
 @click.argument("file", type=click.Path(exists=True, dir_okay=False))
 @click.option(