Skip to content

Test improvement: Convert Embedded GlassFish Maven Plugin Tests to use the latest plugin version #26036

Description

@OndroMih

All the tests in https://github.com/eclipse-ee4j/glassfish/tree/6cab4ce3aad9bc65b52bc761a4aa88634a2bd0aa/appserver/tests/embedded/maven-plugin directory use the old maven plugin version 5.

Convert them to use the latest 8.0 version of the plugin: https://github.com/eclipse-ee4j/glassfish-maven-embedded-plugin

  1. The new version uses a different artifactId: embedded-glassfish-maven-plugin instead of the old maven-embedded-glassfish-plugin(the groupId is the same)

  2. The new version runs Embedded GlassFish in a separate JVM by default. It's OK to keep the default for most of the tests but it would be good to disable this mode for at least one test so that we test it too. For example, the simple test case, or the applicationDispatcher test case. To disable it, set in the plugin config:

<configuration>
    <fork>false</fork>
</configuration>
  1. It's possible to remove the dependencies from the plugin definition in the maven-plugin/pom.xml file and just define the configuration property <version>${project.version}</version>. The plugin will know how to use the glassfish-embedded-all artifact with that version

Metadata

Metadata

Assignees

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions