ArchetypeGenerator doesn't import projects

[kjsmita6]

Hello, the javadoc for ArchetypeGenerator.createArchetypeProjects() says "Creates project structure using Archetype and then imports created project(s)". However, the code for importing seems to have been removed in c76ec87#diff-4742ec5a022dec0edc843e783c76a0a258224fcb273fb08ba3f107e0dc6887cbL139.

Is it importing the projects another way? Calling createArchetypeProjects and then IWorkspaceRoot.getProject().exists() returns false. MavenProjectInfo and LocalProjectScanner are written using java.io.File so I can't imagine it's workspace-aware.

Please let me know the answer or if we are still supposed to do createArchetypeProjects and then import them using ProjectConfigurationManager.importProjects. Thanks.

[kjsmita6]

For context, this is happening because we have a wizard that creates projects. The wizard creates a total of 3 projects: an aggregator project which contains two sub-projects. I am upgrading to the newest m2e release and this is happening because of the change to updating project configurations automatically:

[laeubi]

Archetype generation and importing projects are actually different topic. Because of this this was split into two steps see

m2e-core/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/wizards/MavenProjectWizard.java

Lines 244 to 254 in aa212c4

	protected List<IProject> doCreateMavenProjects(IProgressMonitor monitor) throws CoreException {
	Collection<MavenProjectInfo> projects = M2EUIPluginActivator.getDefault().getArchetypePlugin().getGenerator()
	.createArchetypeProjects(location,
	new MavenArchetype(archetype), //
	groupId, artifactId, version, javaPackage, //
	properties, interactive, monitor);
	return MavenPlugin.getProjectConfigurationManager()
	.importProjects(projects, importConfiguration, new MavenProjectWorkspaceAssigner(workingSets), monitor)
	.stream().filter(r -> r.getProject() != null && r.getProject().exists())
	.map(IMavenProjectImportResult::getProject).toList();
	}

[kjsmita6]

Right, which is why I was saying that the javadoc needs to be updated 😉

[laeubi]

Just open a PR and suggest a change, but keep in mind that ArchetypeGenerator is internal API so other plugins should actually not depend on it!

Making this accessible to others is part of this change, so you probably like to participate there:

• Expose ArchetypeGenerator and ArchetypeManager #922