Skip to content

JVM_getAllEventClasses support - #24125

Merged
gacholio merged 1 commit into
eclipse-openj9:masterfrom
thallium:jfr-getAllEventClasses
Jul 1, 2026
Merged

JVM_getAllEventClasses support#24125
gacholio merged 1 commit into
eclipse-openj9:masterfrom
thallium:jfr-getAllEventClasses

Conversation

@thallium

@thallium thallium commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@thallium

thallium commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@tajila

tajila
tajila reviewed Jun 11, 2026
View reviewed changes
Comment thread runtime/vm/jfr.cpp Outdated
@tajila

tajila commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Please rebase these changes

@thallium
thallium force-pushed the jfr-getAllEventClasses branch 2 times, most recently from 4c8507c to ba4768b Compare June 26, 2026 13:59
tajila
tajila reviewed Jun 26, 2026
View reviewed changes
Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/jfr.cpp Outdated
@thallium
thallium force-pushed the jfr-getAllEventClasses branch from ba4768b to 7d5370d Compare June 26, 2026 16:15
@tajila
tajila requested a review from gacholio June 26, 2026 17:08
@thallium
thallium force-pushed the jfr-getAllEventClasses branch from 7d5370d to 9d3b593 Compare June 26, 2026 19:59
@thallium
thallium marked this pull request as ready for review June 26, 2026 20:00
@gacholio

gacholio commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

@tajila Are you happy with this now?

gacholio
gacholio reviewed Jun 29, 2026
View reviewed changes
Comment thread runtime/jcl/common/jdk_jfr_internal_JVM_common.cpp Outdated
@thallium
thallium force-pushed the jfr-getAllEventClasses branch from 9d3b593 to 8eb70a2 Compare June 29, 2026 13:51
@gacholio

gacholio commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk17,jdk21

@tajila

tajila commented Jun 30, 2026

Copy link
Copy Markdown
Contributor 
ERR] 18:34:30.624 0x15800    j9vm.226    *   ** ASSERTION FAILED ** at /home/jenkins/workspace/Build_JDK17_aarch64_linux_Personal/openj9/runtime/vm/jfr.cpp:2199: ((typeIDTable) != NULL)
14:34:33   [ERR] JVMDUMP039I Processing dump event "traceassert"

@thallium
thallium force-pushed the jfr-getAllEventClasses branch 2 times, most recently from 4052052 to 480abaa Compare June 30, 2026 18:18
@gacholio

gacholio commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk17,jdk21

@gacholio

gacholio commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Assertion failure persists:

        TESTING:
        *** Starting test suite: JFR v2 Tests ***
        Testing: Test JFRv2 cmdline option - no options
        Test start time: 2026/06/30 21:26:45 Coordinated Universal Time
        Running command: "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_aarch64_linux_Personal_testList_2/jdkbinary/j2sdk-image/bin/java"   -XX:+EnableOpenJ9ExperimentalFlightRecording -XX:StartFlightRecording -version
        Time spent starting: 43 milliseconds
        Time spent executing: 2209 milliseconds
        Test result: FAILED
        Output from test:
         [ERR] 21:26:46.347 0x19200    j9vm.226    *   ** ASSERTION FAILED ** at /home/jenkins/workspace/Build_JDK17_aarch64_linux_Personal/openj9/runtime/vm/jfr.cpp:2040: ((typeIDTable) != NULL)

@thallium
JVM_getAllEventClasses support
59f95d0 
Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@thallium
thallium force-pushed the jfr-getAllEventClasses branch from 480abaa to 59f95d0 Compare July 1, 2026 14:44
@thallium

thallium commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Sorry I accidentally deleted this line:

		classLoader->typeIDs = typeIDTable;

which caused the assertion failure.

@gacholio

gacholio commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk17,jdk21

@gacholio
gacholio merged commit 79a92d2 into eclipse-openj9:master Jul 1, 2026
8 checks passed
This was referenced Jul 2, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tajila tajila tajila approved these changes
@gacholio gacholio gacholio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thallium @tajila @gacholio