Skip to content

Avoid compilation failures with memcpy/memset and cfi_startproc - #24278

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64clangUpdate2
Jul 13, 2026
Merged

Avoid compilation failures with memcpy/memset and cfi_startproc#24278
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64clangUpdate2

Conversation

@knn-k

@knn-k knn-k commented Jul 2, 2026 •
edited by keithc-ca
Loading

Copy link
Copy Markdown
Contributor

This commit changes some files to avoid compilation errors with recent Xcode versions.

Co-authored-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

Depends on eclipse-omr/omr#8321.

@knn-k

knn-k commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile amac,alinux64,aix,plinux,win,xlinux,zlinux jdk17

@knn-k

knn-k commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Recent versions of Xcode fail without this change as shown below:

memset:

/Users/openj9/openj9-openjdk-jdk21/openj9/runtime/compiler/control/rossa.cpp:1295:12: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'TR::CodeCacheManager' [-Werror,-Wnontrivial-memcall]
 1295 |     memset(codeCacheManager, 0, sizeof(TR::CodeCacheManager));
      |            ^
/Users/openj9/openj9-openjdk-jdk21/openj9/runtime/compiler/control/rossa.cpp:1295:12: note: explicitly cast the pointer to silence this warning

memcpy:

/Users/openj9/openj9-openjdk-jdk21/openj9/runtime/compiler/ras/HashTable.cpp:183:27: error: first argument in call to 'memcpy' is a pointer to non-trivially copyable type 'TR_HashTableEntry' [-Werror,-Wnontrivial-memcall]
  183 |             memcpy(_table + index, _table + firstCollision, sizeof(TR_HashTableEntry));
      |                    ^
/Users/openj9/openj9-openjdk-jdk21/openj9/runtime/compiler/ras/HashTable.cpp:183:27: note: explicitly cast the pointer to silence this warning

cfi_startproc:

/var/folders/qb/w5wrskj15f9cdl39b_2jgjf80000gn/T/sysv-3c8f16.s:27:2: error: invalid CFI advance_loc expression
 .cfi_def_cfa x1, 40;
 ^

@knn-k knn-k added the comp:jit label Jul 2, 2026
@knn-k

knn-k commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile amac,alinux64,aix,plinux,win,xlinux,zlinux jdk17

@knn-k

knn-k commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins line endings check

@knn-k
knn-k marked this pull request as ready for review July 3, 2026 03:22
@knn-k

knn-k commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

FYI @keithc-ca @pshipton

keithc-ca
keithc-ca reviewed Jul 7, 2026
View reviewed changes
Comment thread runtime/compiler/control/rossa.cpp Outdated
@knn-k
knn-k force-pushed the aarch64clangUpdate2 branch from 018bca9 to 711712d Compare July 8, 2026 00:52
@knn-k
knn-k requested a review from dsouzai as a code owner July 8, 2026 00:52
@knn-k
knn-k marked this pull request as draft July 8, 2026 00:54
@knn-k

knn-k commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

This PR now depends on eclipse-omr/omr#8321, and I turned this PR to the draft state.

@knn-k

knn-k commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile amac,alinux64,aix,plinux,win,xlinux,zlinux jdk17 depends eclipse-omr/omr#8321

@knn-k
Avoid compilation failures with memcpy/memset and cfi_startproc
7936ac3 
This commit changes some files to avoid compilation errors with recent
Xcode versions.

- Remove unnecessary memset()
- Change memcpy() to an assignment
- Change the locations of "cfi_startproc" lines in an assembly code file
  (based on libffi/libffi#857)

Co-authored-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
knn-k force-pushed the aarch64clangUpdate2 branch from 711712d to 7936ac3 Compare July 8, 2026 01:14
@knn-k

knn-k commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile amac,alinux64,aix,plinux,win,xlinux,zlinux jdk17 depends eclipse-omr/omr#8321

@knn-k

knn-k commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

AIX build was aborted after 10 hours:

All nodes of label ‘ci.role.build&&hw.arch.ppc64&&sw.os.aix.7_2&&sw.tool.c++runtime.16_1’ are offline

@knn-k

knn-k commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile aix jdk17 depends eclipse-omr/omr#8321

@pshipton

pshipton commented Jul 8, 2026

Copy link
Copy Markdown
Member

There is an infra issue, I already opened an internal issue.
https://github.ibm.com/runtimes/infrastructure/issues/12076

@knn-k knn-k mentioned this pull request Jul 10, 2026
Merged
@0xdaryl 0xdaryl added the depends:omr Pull request is dependent on a corresponding change in OMR label Jul 10, 2026
@knn-k

knn-k commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

eclipse-omr/omr#8321 has promoted in openj9-omr.

@knn-k

knn-k commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile amac jdk17

@knn-k
knn-k marked this pull request as ready for review July 13, 2026 02:12
@knn-k

knn-k commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Jenkins compile aix jdk17

@keithc-ca
keithc-ca merged commit f5dbbc3 into eclipse-openj9:master Jul 13, 2026
11 checks passed
@knn-k
knn-k deleted the aarch64clangUpdate2 branch July 13, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes
@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees

No one assigned

Labels

comp:jit depends:omr Pull request is dependent on a corresponding change in OMR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knn-k @pshipton @keithc-ca @0xdaryl