Optimize findOrCreateMethodSymRef for single method lookup - #24287
Merged
mpirvu merged 1 commit intoJul 9, 2026
Merged
Conversation
mpirvu
reviewed
Jul 6, 2026
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I have some small inline comments.
An alternative could have been to modify
TR::SymbolReference *TR_J9VMBase::findOrCreateMethodSymRef(TR::Compilation *comp,
TR::ResolvedMethodSymbol *owningMethodSym, const char *classSig, const char *methodSig)
AbdallahAbd05
force-pushed
the
specializeFindOrCreateMethodSymRef
branch
2 times, most recently
from
July 6, 2026 21:04
669a7d7 to
c2bf015
Compare
mpirvu
reviewed
Jul 7, 2026
AbdallahAbd05
force-pushed
the
specializeFindOrCreateMethodSymRef
branch
from
July 7, 2026 15:53
c2bf015 to
6d1a1c6
Compare
Contributor
|
jenkins test sanity all jdk25 |
Contributor
Author
|
The unstable s390x_linux sanity.openjdk test is unrelated to my change, and is already documented in #22110 |
Contributor
|
Tests have passed. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a specialized path for the
methodCount=1case infindOrCreateMethodSymRefthat instead usesgetResolvedMethodForNameAndSignature()directly, avoiding the expensive allocation ofTR_ResolvedMethodobjects for every method in the class.Issue: #23591
Related PRs: #24088, #24223, and eclipse-omr/omr#8293