Skip to content

CloseUnrelatedProjectsAction.resourceChanged() is never called #3943

@basilevs

Description

@basilevs

org.eclipse.ui.actions.CloseUnrelatedProjectsAction.resourceChanged(IResourceChangeEvent) is never called when resources are changed. This action is never registered as a resource listener.

Part of the action logic relies on this method, which causes confusion.

I would suggest removing interface org.eclipse.core.resources.IResourceChangeListener from org.eclipse.ui.actions.CloseUnrelatedProjectsAction and org.eclipse.ui.actions.CloseResourceAction but this seems to be breaking API.

Adding the actions as listeners is probably feasible, but had apparently never been done.

This defect complicates performance optimizations attempted in #2636.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions