Skip to content

Invalid CORS Configuration Breaks Browser Clients #34

@jona42-ui

Description

@jona42-ui

The API sets Access-Control-Allow-Origin: localhost. This is an invalid CORS header value (it must be a full origin like http://localhost:8080 or * )

I would suggest we change the CORS header to Access-Control-Allow-Origin: * for public access, or dynamically reflect the Origin header if credentials are required.

what do you think about this @wiresio or what would be the best practice.

Look at also at:

  1. Add a default CORS setting sifis-home/wot-serve#20
  2. Let user configure Access-Control-Allow-Origin header node-wot#941

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions