Skip to content

Commit 2c6bd2f

Browse files
authored
Merge pull request #129 from eduralph/docs/128-reviewer-grounding-worktree
docs(check): $PDCA_TARGET is the per-cycle worktree, not the sibling checkout
2 parents 5059581 + 61f4c14 commit 2c6bd2f

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

docs/05-check.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,15 @@ creep. Its output, `check-review.md`, is **advisory** — it annotates, it never
9898
gates. The blocking path contains no LLM at all.
9999

100100
The reviewer runs in an isolation sandbox (only `{patch.diff, brief.md,
101-
check-gates.json}` are present), so the driver resolves the brief's target checkout and
102-
hands it over as **`$PDCA_TARGET`** (read-only; for a `claude` reviewer also via
103-
`--add-dir`). The reviewer grounds every citation there and is told **not** to wander
104-
into other checkouts on the machine — without this it can't ground, or hunts the
105-
filesystem for "the target" (issue #75).
101+
check-gates.json}` are present), so the driver hands it a read-only grounding target as
102+
**`$PDCA_TARGET`** (for a `claude` reviewer also via `--add-dir`). That target is the
103+
**per-cycle worktree** ([step 04](04-do.md)) — pinned to the *same* base the gates ran
104+
against and carrying the patch — so a stale or unreadable sibling checkout can't drift
105+
the reviewer's grounding (issue #120); when worktree isolation is off it falls back to
106+
the brief's target checkout, freshly fetched (refs only — never resetting your working
107+
tree). The reviewer grounds every citation there and is told **not** to wander into
108+
other checkouts on the machine — without this it can't ground, or hunts the filesystem
109+
for "the target" (issue #75).
106110

107111
### Optional advisory reviewers (a second lens)
108112

0 commit comments

Comments
 (0)