Skip to content

bug: workspace still being created on error #74

Description

@mtrajano

Tried creating a workspace off an invalid revision it looks like it errored out while still creating the workspace, causing me to have to clean up an invalid command run. To me the workspace should not be created on error. I'm not a rust dev but I can try to submit a PR assuming your OK with the change

❯ nv cd -c -r default intake-improvements
error: jj command failed: jj workspace add --name intake-improvements -r default /Users/mtrajano/dev/pontal/pontal-agents/../pontal-agents.intake-improvements
Created workspace in "../pontal-agents.intake-improvements"
Error: Revision `default` doesn't exist

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions