Simplify download

Author: elcuervo

Rakefile

@@ -8,40 +8,6 @@ RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
 
-namespace :model do
-  DEFAULT_REPO_ID = 'cuerbot/gliner2-multi-v1'
-  DEFAULT_MODEL_FILE = 'model_fp16.onnx'
-  DEFAULT_MODEL_SUBDIR = 'onnx'
-
-  desc 'Downloads a test model to tmp/ (REPO_ID=... MODEL_FILE=model_fp16.onnx)'
-  task :pull do
-    repo_id = ENV['REPO_ID'] || DEFAULT_REPO_ID
-    model_file = ENV['MODEL_FILE'] || DEFAULT_MODEL_FILE
-    model_subdir = ENV['MODEL_SUBDIR'] || DEFAULT_MODEL_SUBDIR
-
-    dir = File.expand_path("tmp/models/#{repo_id.tr('/', '__')}", __dir__)
-    FileUtils.mkdir_p(dir)
-
-    base = "https://huggingface.co/#{repo_id}/resolve/main"
-    base = "#{base}/#{model_subdir}" unless model_subdir.nil? || model_subdir.empty?
-    files = ['tokenizer.json', 'config.json', model_file]
-    client = HTTPX.plugin(:follow_redirects).with(max_redirects: 5)
-
-    files.each do |file|
-      dest = File.join(dir, file)
-      next if File.exist?(dest) && File.size?(dest)
-
-      response = client.get("#{base}/#{file}")
-      raise "Download failed: #{base}/#{file} (status: #{response.status})" unless response.status.between?(200, 299)
-
-      File.binwrite(dest, response.body.to_s)
-    end
-
-    puts "Downloaded model to: #{dir}"
-    puts "Use with: GLINER_MODEL_DIR=#{dir}"
-  end
-end
-
 namespace :spec do
   desc 'Runs real-model integration test (downloads ~357MB unless GLINER_MODEL_DIR is set)'
   task :integration do

bin/console

@@ -9,6 +9,7 @@ end
 
 require "gliner"
 require "irb"
+require "debug"
 
 model_dir = ARGV[0] || ENV["GLINER_MODEL_DIR"]
 model_file = ENV["GLINER_MODEL_FILE"]

gliner.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'irb', '~> 1.16.0'
   spec.add_development_dependency 'rspec', '~> 3.13'
   spec.add_development_dependency 'rubocop', '~> 1.50'
+  spec.add_development_dependency 'debug', '~> 1.11'
 
   spec.metadata['rubygems_mfa_required'] = 'true'
 end

lib/gliner.rb

@@ -141,34 +141,31 @@ def apply_model_source!
       config.model = download_default_model
     end
 
+    def client
+      @client ||= HTTPX.plugin(:follow_redirects)
+    end
+
     def download_default_model
       model_file = model_file_for_variant(config.variant)
-      root = File.expand_path('..', __dir__)
-      dir = File.join(root, '.cache', 'models', HF_REPO.tr('/', '__'))
+      dir = File.join(Dir.pwd, '.cache', 'gliner', HF_REPO.tr('/', '__'))
 
       FileUtils.mkdir_p(dir)
 
       files = ['tokenizer.json', 'config.json', model_file]
-      client = HTTPX.plugin(:follow_redirects)
 
       files.each do |file|
-        dest = File.join(dir, file)
-        next if File.exist?(dest) && File.size?(dest)
+        target = File.join(dir, file)
 
-        download_file!(client, "#{DEFAULT_MODEL_BASE}/#{file}", dest)
+        next if File.exist?(target) && File.size?(target)
+
+        client
+          .get("#{DEFAULT_MODEL_BASE}/#{file}")
+          .copy_to(target)
       end
 
       dir
     end
 
-    def download_file!(client, url, dest)
-      response = client.get(url)
-
-      raise Error, "Download failed: #{url} (status: #{response.error})" if response.error
-
-      File.binwrite(dest, response.body.to_s)
-    end
-
     def env_model_dir
       dir = ENV.fetch('GLINER_MODEL_DIR', nil)
       return nil if dir.nil? || dir.empty?