Optimise Filter by having reverse index per node

Author: robacourt

packages/sync-service/lib/electric/shapes/consumer.ex

@@ -7,7 +7,7 @@ defmodule Electric.Shapes.Consumer do
   alias Electric.Shapes.Consumer.PlanExecutor
   alias Electric.Shapes.Consumer.State
   alias Electric.Shapes.DnfPlan
-  alias Electric.Shapes.Filter.SubqueryIndex
+  alias Electric.Shapes.Filter.Indexes.SubqueryIndex
 
   import Electric.Shapes.Consumer.State, only: :macros
   require Electric.Replication.LogOffset

packages/sync-service/lib/electric/shapes/consumer/plan_executor.ex

@@ -6,7 +6,7 @@ defmodule Electric.Shapes.Consumer.PlanExecutor do
   alias Electric.Shapes.Consumer.Plan
   alias Electric.Shapes.Consumer.Subqueries
   alias Electric.Shapes.Consumer.Subqueries.QueryRow
-  alias Electric.Shapes.Filter.SubqueryIndex
+  alias Electric.Shapes.Filter.Indexes.SubqueryIndex
   alias Electric.LogItems
   alias Electric.Replication.LogOffset
   alias Electric.ShapeCache

packages/sync-service/lib/electric/shapes/filter.ex

@@ -20,7 +20,7 @@ defmodule Electric.Shapes.Filter do
   alias Electric.Replication.Changes.UpdatedRecord
   alias Electric.Shapes.DnfPlan
   alias Electric.Shapes.Filter
-  alias Electric.Shapes.Filter.SubqueryIndex
+  alias Electric.Shapes.Filter.Indexes.SubqueryIndex
   alias Electric.Shapes.Filter.WhereCondition
   alias Electric.Shapes.Shape
   alias Electric.Telemetry.OpenTelemetry
@@ -33,7 +33,6 @@ defmodule Electric.Shapes.Filter do
     :where_cond_table,
     :eq_index_table,
     :incl_index_table,
-    :subquery_cond_table,
     :subquery_index
   ]
 
@@ -48,7 +47,6 @@ defmodule Electric.Shapes.Filter do
       where_cond_table: :ets.new(:filter_where, [:set, :private]),
       eq_index_table: :ets.new(:filter_eq, [:set, :private]),
       incl_index_table: :ets.new(:filter_incl, [:set, :private]),
-      subquery_cond_table: :ets.new(:filter_subquery_cond, [:set, :private]),
       subquery_index: SubqueryIndex.new(Keyword.take(opts, [:stack_id]))
     }
   end

packages/sync-service/lib/electric/shapes/filter/index.ex

@@ -10,11 +10,11 @@ defmodule Electric.Shapes.Filter.Index do
   alias Electric.Shapes.Filter
   alias Electric.Shapes.Filter.Indexes.EqualityIndex
   alias Electric.Shapes.Filter.Indexes.InclusionIndex
-  alias Electric.Shapes.Filter.Indexes.SubqueryNode
+  alias Electric.Shapes.Filter.Indexes.SubqueryIndex
 
   defp module_for("="), do: EqualityIndex
   defp module_for("@>"), do: InclusionIndex
-  defp module_for("subquery"), do: SubqueryNode
+  defp module_for("subquery"), do: SubqueryIndex
 
   # "in" delegates to EqualityIndex, registering the shape under each value
   def add_shape(%Filter{} = filter, where_cond_id, shape_id, %{operation: "in"} = optimisation) do