Skip to content

Commit 405cdc7

Browse files
alcoclaude
authored andcommitted
Update progress log with CI and review results
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 6b6d7a7 commit 405cdc7

File tree

1 file changed

+12
-1
lines changed
  • .agent-tasks/2026-03-23--12--ets-observability

1 file changed

+12
-1
lines changed

.agent-tasks/2026-03-23--12--ets-observability/progress.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,32 @@
2424
- Rebased on origin/main successfully
2525
- Implemented integration (opts, periodic measurement, metrics)
2626
- Ran internal code review (review-round-1.md)
27-
- Addressed review findings:
27+
- Addressed internal review findings:
2828
- Removed `String.to_atom/1` from `table_type/1` to prevent atom exhaustion
2929
- Handled race condition when table deleted between `:ets.all()` and `:ets.info/2`
3030
- Fixed test assertions: replaced silent `if` guards with proper `assert` calls
3131
- Added `on_exit` callbacks for reliable ETS table cleanup in tests
3232
- Fixed test table names to use UUID-like suffixes for correct type grouping
3333
- All 13 tests passing, compilation clean with --warnings-as-errors
3434
- Force-pushed rebased branch, updated PR description, added `claude` label
35+
- CI: electric-telemetry build passes, formatting passes
36+
- CI: `CallHomeReporterTest` has pre-existing flaky failures (unrelated to our changes)
37+
- Claude Code Review bot (round 1): passed, feedback addressed
38+
- Fixed docstring examples to show string types instead of atoms
39+
- Hoisted `:erlang.system_info(:wordsize)` to module attribute
40+
- Dismissed `.agent-tasks` feedback (intentional per project convention)
41+
- Claude Code Review bot (round 2): timed out (infrastructure issue), no new feedback posted
3542

3643
### Dismissed review items
3744
- UUID regex too greedy for underscores: Edge case for Electric's specific naming patterns, acceptable
3845
- Inconsistent field naming (type_table_count vs table_count): Different data structures with different semantics
3946
- `top_memory_stats` unused in integration: Intended for IEx debugging
4047
- Performance concern about polling: Same trade-off as existing process_memory, acceptable
48+
- Two sequential reduce passes: Not worth the complexity for a minor optimization
49+
- Dead code branch (`if count > 0`): Harmless defensive guard
4150

4251
### Operational issues
4352
- Old worktree existed at `/home/alco/code/workspaces/electric/ets-observability`, had to remove it first
4453
- Husky pre-commit hook not executable (warning only, doesn't block)
54+
- Named ETS tables in tests auto-deleted when test process exits; `on_exit` callbacks need try/rescue not `:ets.info` checks
55+
- `mix format` required for try/rescue blocks in `on_exit` (one-liners not allowed)

0 commit comments

Comments
 (0)