Skip to content

Electron binary path resolver incorrect assumption based on ".app" subpath matching #95

@WholeMilk

Description

@WholeMilk

I have an Electron project with a local path including a folder name of ../my.app.win/.. that is causing the Electron binary resolution logic below to mistakenly think it is targeting macOS platform even though I'm working on Windows:

if (pathToElectron.includes('.app')) {
My suggestion would be to update the pathToFuseFile() function to perform a fs.existsSync() check before returning the Electron binary path and/or check current OS type from Node's os.type() call.
I believe the same issue exists for this check as well:
if (fuseConfig.resetAdHocDarwinSignature && pathToElectron.includes('.app')) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions