Skip to content

Commit 3727e1c

Browse files
Reference upstream issue in sideEffectsCache workaround comment
1 parent 577c303 commit 3727e1c

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

pnpm-workspace.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ allowBuilds:
2020
# so its postinstall build is redundant. Same reasoning as in Core.
2121
esbuild: false
2222
# Do not reuse pnpm's cache of postinstall (side effect) output. Since pnpm 8.7
23-
# the content addressable store keeps such files as plain copies, not symlinks
24-
# (pnpm/pnpm#7691). dugite's postinstall lays down git, whose git-core is ~145
25-
# symlinks to one binary. Restoring that from a warm store (the CI pnpm cache)
26-
# flattens them into 145 full copies, which doubled the packaged macOS app.
27-
# With this off dugite re-extracts git each install, so the symlinks survive.
23+
# the content addressable store keeps such files as plain copies, not symlinks.
24+
# dugite's postinstall lays down git, whose git-core is ~145 symlinks to one
25+
# binary. Restoring that from a warm store (the CI pnpm cache) flattens them
26+
# into 145 full copies, which doubled the packaged macOS app. With this off
27+
# dugite re-extracts git each install, so the symlinks survive.
28+
# Reported as pnpm/pnpm#12859 (see also #7691). Remove once that is fixed.
2829
sideEffectsCache: false
2930
# Temporary: pnpm's default minimumReleaseAge policy (about one day) rejects
3031
# freshly published packages on a clean install, which is what CI runs.

0 commit comments

Comments
 (0)