Cleanup handling of tab icons

Author: lenemter

src/Application.vala

@@ -174,21 +174,23 @@ public class Terminal.Application : Gtk.Application {
                 return;
             }
 
-            var process_string = _("Process completed");
-            var process_icon = new ThemedIcon ("process-completed-symbolic");
+            var notification_title = _("Process completed");
+            var notification_icon = new ThemedIcon ("process-completed-symbolic");
+            var tab_state = TerminalWidget.TabState.COMPLETED;
             if (exit_status != 0) {
-                process_string = _("Process exited with errors");
-                process_icon = new ThemedIcon ("process-error-symbolic");
+                notification_title = _("Process exited with errors");
+                notification_icon = new ThemedIcon ("process-error-symbolic");
+                tab_state = ERROR;
             }
 
             if (terminal != terminal.main_window.current_terminal) {
-                terminal.tab.icon = process_icon;
+                terminal.tab_state = tab_state;
             }
 
             if (!(get_active_window ().is_active)) {
-                var notification = new Notification (process_string);
+                var notification = new Notification (notification_title);
                 notification.set_body (process);
-                notification.set_icon (process_icon);
+                notification.set_icon (notification_icon);
                 notification.set_default_action_and_target_value ("app.process-finished", new Variant.string (id));
                 send_notification ("process-finished-%s".printf (id), notification);
 
@@ -215,7 +217,7 @@ public class Terminal.Application : Gtk.Application {
             return;
         }
 
-        terminal.tab.icon = null;
+        terminal.tab_state = NONE;
         withdraw_notification ("process-finished-%s".printf (id));
 
         terminal.main_window.disconnect (tab_change_handler);

src/MainWindow.vala

@@ -303,7 +303,7 @@ namespace Terminal {
                     return;
                 }
 
-                term.tab.icon = null; // Assume only process icons are set
+                term.tab_state = NONE;
             });
 
             notebook.tab_bar.bind_property ("tabs-revealed", new_tab_revealer, "reveal-child", SYNC_CREATE | INVERT_BOOLEAN);

src/Widgets/TerminalView.vala

@@ -169,6 +169,20 @@ public class Terminal.TerminalView : Granite.Bin {
         terminal_widget.bind_property ("current-working-directory", tab, "tooltip");
         terminal_widget.tab = tab;
 
+        terminal_widget.notify["tab-state"].connect (() => {
+            switch (terminal_widget.tab_state) {
+                case NONE:
+                    tab.icon = null;
+                    break;
+                case COMPLETED:
+                    tab.icon = new ThemedIcon ("process-completed-symbolic");
+                    break;
+                case ERROR:
+                    tab.icon = new ThemedIcon ("process-error-symbolic");
+                    break;
+            }
+        });
+
         //Set correct label now to avoid race when spawning shell
 
         terminal_widget.set_font (term_font);

src/Widgets/TerminalWidget.vala

@@ -5,10 +5,10 @@
 
 namespace Terminal {
     public class TerminalWidget : Vte.Terminal {
-        enum DropTargets {
-            URILIST,
-            STRING,
-            TEXT
+        public enum TabState {
+            NONE,
+            COMPLETED,
+            ERROR
         }
 
         internal const string DEFAULT_LABEL = _("Terminal");
@@ -18,6 +18,7 @@ namespace Terminal {
         static int terminal_id_counter = 0;
         private bool init_complete;
         public bool resized {get; set;}
+        public TabState tab_state { get; set; default = NONE; }
 
         GLib.Pid child_pid;
         GLib.Pid fg_pid;