Skip to content

Commit 7b75f22

Browse files
fix(dialyzer): pass string module suffix to Igniter.Project.Module
Igniter.Project.Module.module_name/2 is specced as (Igniter.t(), String.t()). Using the atom MainWindow broke Dialyzer (invalid call, no_return on igniter/1, and spurious unused_fun on private helpers). Use "MainWindow" consistently. Unblocks CI for #69 Co-authored-by: Dominic Letz <dominicletz@users.noreply.github.com>
1 parent 59bf274 commit 7b75f22

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/mix/tasks/desktop.install.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ if Code.ensure_loaded?(Igniter.Mix.Task) do
5050
menu = Igniter.Project.Module.module_name(igniter, "Menu")
5151
menubar = Igniter.Project.Module.module_name(igniter, "MenuBar")
5252
gettext = Igniter.Libs.Phoenix.web_module_name(igniter, "Gettext")
53-
main_window = Igniter.Project.Module.module_name(igniter, MainWindow)
53+
main_window = Igniter.Project.Module.module_name(igniter, "MainWindow")
5454

5555
igniter
5656
|> Igniter.compose_task("igniter.add", ["desktop"])
@@ -63,7 +63,7 @@ if Code.ensure_loaded?(Igniter.Mix.Task) do
6363
quote do
6464
[
6565
app: unquote(app),
66-
id: unquote(Igniter.Project.Module.module_name(igniter, MainWindow)),
66+
id: unquote(Igniter.Project.Module.module_name(igniter, "MainWindow")),
6767
title: unquote(to_string(app)),
6868
size: {600, 500},
6969
menubar: unquote(menubar),

0 commit comments

Comments
 (0)