Skip to content

Commit 6f458cd

Browse files
committed
Polish infrastructure merge review notes
1 parent 4ba9397 commit 6f458cd

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/Elsa.PackageManifest.Generator.Core/Generation/ManifestMetadataMerger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private static IReadOnlyList<ManifestInfrastructureRequirementReference> MergeIn
9696
IReadOnlyList<ManifestInfrastructureRequirementReference> first,
9797
IReadOnlyList<InfrastructureRequirementOverride>? second)
9898
{
99-
if (second is null)
99+
if (second is null || second.Count == 0)
100100
return first;
101101

102102
var result = first.ToList();

tests/Elsa.PackageManifest.Generator.Testing/CShellsFeatureFixtures.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ internal sealed class ManifestExtensionAttribute(string key, string value) : Att
8585
public string Value { get; } = value;
8686
}
8787
88-
[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
88+
[AttributeUsage(AttributeTargets.Class, AllowMultiple = true, Inherited = false)]
8989
internal sealed class ManifestInfrastructureAttribute(string id, string kind) : Attribute
9090
{
9191
public string Id { get; } = id;

0 commit comments

Comments
 (0)